Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-grid gutter margin bug on rows with gaps #4515

Closed
russelltrafford opened this issue May 12, 2017 · 3 comments · Fixed by #9128
Closed

md-grid gutter margin bug on rows with gaps #4515

russelltrafford opened this issue May 12, 2017 · 3 comments · Fixed by #9128
Assignees
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@russelltrafford
Copy link

russelltrafford commented May 12, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

A gap is left, tile goes to the next line, and margins are adhered to as previous rows.

What is the current behavior?

A gap is left, tile goes to the next line, but margin is too negative, resulting in the tile starting further left on the page. In the plunker, this is box 11.

What are the steps to reproduce?

https://plnkr.co/edit/hzjETIKN381wQg1Fqhka?p=preview
Create a grid, and do it in such a way that there is not enough room on the current row to have the item, so it has to be forced to the next line. In this case, the margins then get messed up.

What is the use-case or motivation for changing an existing behavior?

Its a bug which results in the margin being off. I'm sure this is not wanted behaviour.

Which versions of Angular, Material, OS, browsers are affected?

The current versions on the material2 demos. I forked this example plunker from the material2 example code at https://material.angular.io/components/component/grid-list

Is there anything else we should know?

Nope, don't think so. Thanks! Everything else on this grid was fantastic, I just noticed this one little odd piece of behaviour.

Screenshot if needed:
screen shot 2017-05-12 at 2 13 14 pm

@lax20attack
Copy link

lax20attack commented Jun 4, 2017

Very simple to reproduce:

https://plnkr.co/edit/ohfAcDbnBCBudSFs6118?p=preview

@josephperrott
Copy link
Member

here is a current reproduction

@josephperrott josephperrott added the P2 The issue is important to a large percentage of users, with a workaround label Sep 27, 2017
@crisbeto crisbeto self-assigned this Dec 26, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 26, 2017
…ound

Fixes and issue in the grid list where a tile, for which we couldn't find a gap in which to put it, is being pulled outside the grid due to the index defaulting to -1.

Fixes angular#4515.
jelbourn pushed a commit that referenced this issue Jan 21, 2018
…ound

Fixes and issue in the grid list where a tile, for which we couldn't find a gap in which to put it, is being pulled outside the grid due to the index defaulting to -1.

Fixes #4515.
jelbourn pushed a commit that referenced this issue Jan 23, 2018
…ound (#9128)

Fixes and issue in the grid list where a tile, for which we couldn't find a gap in which to put it, is being pulled outside the grid due to the index defaulting to -1.

Fixes #4515.
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 29, 2018
…ound (angular#9128)

Fixes and issue in the grid list where a tile, for which we couldn't find a gap in which to put it, is being pulled outside the grid due to the index defaulting to -1.

Fixes angular#4515.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants