Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu, autocomplete, and datepicker should remove CSS classes from inert panel element #4484

Closed
jelbourn opened this issue May 11, 2017 · 2 comments · Fixed by #4800
Closed
Assignees
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@jelbourn
Copy link
Member

If you have

<md-menu #options class="borange">
  ...
</md-menu>

The css classes are copied to the panel element inside the overlay. However, the classes also remain on the empty <md-menu> element in the page. We should remove all classes from the md-menu element.

This behavior should apply to menu, autocomplete, and datepicker.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label May 11, 2017
@sabithpocker
Copy link

sabithpocker commented May 12, 2017

Does this affect md-basic-chip as well? I had a similar problem when using class with md-basic-chip but worked fine when ng-class was used instead.

Link to Original Issue

UPDATE: Never mind, I can see that this is un-related.

crisbeto added a commit to crisbeto/material2 that referenced this issue May 25, 2017
Removes the classes from the inert `md-menu` element, after they're transferred to the menu panel.

Fixes angular#4484.
andrewseguin pushed a commit that referenced this issue Jun 8, 2017
Removes the classes from the inert `md-menu` element, after they're transferred to the menu panel.

Fixes #4484.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants