Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't bind to 'xPosition' since it isn't a known property of 'md-menu'. #4169

Closed
fxck opened this issue Apr 20, 2017 · 3 comments · Fixed by #4213
Closed

Can't bind to 'xPosition' since it isn't a known property of 'md-menu'. #4169

fxck opened this issue Apr 20, 2017 · 3 comments · Fixed by #4213
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@fxck
Copy link
Contributor

fxck commented Apr 20, 2017 •
edited
Loading

Is there any reason these are @Attributes instead of @Inputs?

I'm trying to pass down the position from a parent component.

@kara @jelbourn
@crisbeto crisbeto self-assigned this Apr 20, 2017
@jelbourn
Copy link
Member

I think I discussed this with @kara before and there's no major reason they can't be @Inputs

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Apr 20, 2017
@kara
Copy link
Contributor

kara commented Apr 20, 2017

Yeah, we just haven't had a chance to implement it.

@kara kara added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Apr 20, 2017
@willshowell willshowell mentioned this issue Apr 24, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 27, 2017
@crisbeto
fix(menu): unable to bind to xPosition and yPosition
b6af4d0 
Fixes not being able to use data bindings on the `xPosition` and `yPosition` properties.

**Note:** These changes could be considered breaking, if somebody was implementing the `MdMenuPanel` interface.

Fixes angular#4169.
@jelbourn jelbourn mentioned this issue Apr 27, 2017
Closed
@crisbeto crisbeto mentioned this issue Apr 28, 2017
Closed
andrewseguin pushed a commit that referenced this issue May 2, 2017
@crisbeto @andrewseguin
fix(menu): unable to bind to xPosition and yPosition (#4213)
1fd50aa 
Fixes not being able to use data bindings on the `xPosition` and `yPosition` properties.

**Note:** These changes could be considered breaking, if somebody was implementing the `MdMenuPanel` interface.

Fixes #4169.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(menu): unable to bind to xPosition and yPosition crisbeto/material2
4 participants
@jelbourn @fxck @kara @crisbeto