Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented BREAKING CHANGES #4002

Closed
shlomiassaf opened this issue Apr 9, 2017 · 7 comments
Closed

Undocumented BREAKING CHANGES #4002

shlomiassaf opened this issue Apr 9, 2017 · 7 comments
Assignees
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@shlomiassaf
Copy link
Contributor

shlomiassaf commented Apr 9, 2017

@jelbourn Hi,

While upgrading I found some undocumented breaking changes.

  • the config property is no longer part of MdDialogRef, now one needs to inject the MD_DIALOG_DATA token

  • DomProjectionHost and DomProjection are no longer part of @angular/material, couldn't find a replacement of documentation for it.

this is it for now

ghoullier referenced this issue Apr 10, 2017
* Adds enter/exit animations to the dialog.
* Refactors the `MdDialogContainer` and `MdDialogRef` to accommodate the animations.
* Fixes some test failures due to the animations.
* Allows for the backdrop to be detached before the rest of the overlay, in order to allow for it to be transitioned in parallel.

Fixes #2665.
@ghoullier
Copy link

@shlomiassaf you can access to the dialog config via the following property

export class DialogComponent {
  constructor(private dialog: MdDialogRef<any>) {
    const config = dialog._containerInstance.dialogConfig;
  }
}

@shlomiassaf
Copy link
Contributor Author

I didn't try.

The _containerInstance seems like a private variable so I wouldn't want to use it and later face issues.

anyway, the MD_DIALOG_DATA is how to get the data now...

@ghoullier
Copy link

Yes but MD_DIALOG_DATA allows you to retrive dialogConfig via DialogInjector but dialogInjector reference seems to be not exposed.

@shlomiassaf
Copy link
Contributor Author

I don't understand what you mean...
MD_DIALOG_DATA returns the data object supplied to the confit.

I don't think the config exposed.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Apr 10, 2017
@jelbourn jelbourn self-assigned this Apr 10, 2017
ghoullier added a commit to zetapush/angular-zetapush-starter that referenced this issue Apr 10, 2017
@xuanshenbo
Copy link

Should this be closed by #4126?

@jelbourn
Copy link
Member

Yes

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

4 participants