Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-list-icon is not aligned with global box-sizing: inherit #3863

Closed
willshowell opened this issue Mar 31, 2017 · 1 comment · Fixed by #3876
Closed

md-list-icon is not aligned with global box-sizing: inherit #3863

willshowell opened this issue Mar 31, 2017 · 1 comment · Fixed by #3876
Assignees
@crisbeto

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Bug

It's pretty common to globally apply inherited box sizing to all elements:

html {
  box-sizing: border-box;
}
*, *:before, *:after {
  box-sizing: inherit;
}

This causes the md-list-icon to no longer keep the correct size, because it is inheriting border-box from .mat-list-item-content. It should explicitly use content-box.

What are the steps to reproduce?

http://plnkr.co/edit/nDwtfSsqTrotyZpNfr5I?p=preview
@crisbeto crisbeto added the has pr label Apr 2, 2017
@crisbeto crisbeto self-assigned this Apr 2, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 2, 2017
@crisbeto
fix(list): set explicit box-sizing on icon
297bc8d 
Sets an explicit `box-sizing` on the icons inside of lists, in order to avoid alignment issues if the consumer uses `border-box` globally.

Fixes angular#3863.
@crisbeto crisbeto mentioned this issue Apr 2, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 12, 2017
@crisbeto
fix(list): set explicit box-sizing on icon
9e69344 
Sets an explicit `box-sizing` on the icons inside of lists, in order to avoid alignment issues if the consumer uses `border-box` globally.

Fixes angular#3863.
jelbourn pushed a commit that referenced this issue Apr 17, 2017
@crisbeto @jelbourn
fix(list): set explicit box-sizing on icon (#3876)
e263fb7 
Sets an explicit `box-sizing` on the icons inside of lists, in order to avoid alignment issues if the consumer uses `border-box` globally.

Fixes #3863.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(list): set explicit box-sizing on icon crisbeto/material2
2 participants
@crisbeto @willshowell