-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ripple Config #3454
Comments
Great idea. I need to see how this should be done, because I want to avoid issues with the |
* Adds a new DI token that can be used to specify global ripple options. * The `RippleRef` options are not related to the `MD_DISABLE_RIPPLES` DI token (for API convenience) Closes angular#3454
* Adds a new DI token that can be used to specify global ripple options. * The `RippleRef` options are not related to the `MD_DISABLE_RIPPLES` DI token (for API convenience) Closes angular#3454
@krigton I was made aware of the fact that I misread the issue. I actually don't think it would be elegant to provide a DI token to only set options for the If we would support such DI token, then we would need to do this for other components as well. |
Yes, my idea was that or a global configuration which affects all the ripples, or each component could have it's own configuration |
@krigton Yeah I misread it and understood you requested a config that affects all ripple elements. Right now with #3463, developers are able to specify a global base-speed. |
@devversion thanks, that's might be enough for us for now. thank you very much |
@krigton You are welcome. Thanks for the idea! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Change the ripple config for all buttons for example
What is the expected behavior?
What is the current behavior?
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
What is the use-case or motivation for changing an existing behavior?
It prevents using css hacks and it's possible to fine tune the ripple for all elements for a certain type
Which versions of Angular, Material, OS, browsers are affected?
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: