Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple Config #3454

Closed
csabattilas opened this issue Mar 6, 2017 · 7 comments · Fixed by #3463
Closed

Ripple Config #3454

csabattilas opened this issue Mar 6, 2017 · 7 comments · Fixed by #3463
Assignees
Labels
design This issue needs design work before implementing P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@csabattilas
Copy link

Bug, feature request, or proposal:

Change the ripple config for all buttons for example

What is the expected behavior?

What is the current behavior?

What are the steps to reproduce?

Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U

What is the use-case or motivation for changing an existing behavior?

It prevents using css hacks and it's possible to fine tune the ripple for all elements for a certain type

Which versions of Angular, Material, OS, browsers are affected?

Is there anything else we should know?

@devversion devversion self-assigned this Mar 6, 2017
@devversion
Copy link
Member

Great idea. I need to see how this should be done, because I want to avoid issues with the MD_DISABLE_RIPPLES token.

@devversion devversion added design This issue needs design work before implementing P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Mar 6, 2017
devversion added a commit to devversion/material2 that referenced this issue Mar 6, 2017
* Adds a new DI token that can be used to specify global ripple options.
* The `RippleRef` options are not related to the `MD_DISABLE_RIPPLES` DI token (for API convenience)

Closes angular#3454
devversion added a commit to devversion/material2 that referenced this issue Mar 6, 2017
* Adds a new DI token that can be used to specify global ripple options.
* The `RippleRef` options are not related to the `MD_DISABLE_RIPPLES` DI token (for API convenience)

Closes angular#3454
@devversion
Copy link
Member

@krigton I was made aware of the fact that I misread the issue. I actually don't think it would be elegant to provide a DI token to only set options for the button component (or others).

If we would support such DI token, then we would need to do this for other components as well.

@csabattilas
Copy link
Author

Yes, my idea was that or a global configuration which affects all the ripples, or each component could have it's own configuration

@devversion
Copy link
Member

devversion commented Mar 10, 2017

@krigton Yeah I misread it and understood you requested a config that affects all ripple elements.

Right now with #3463, developers are able to specify a global base-speed.

@csabattilas
Copy link
Author

@devversion thanks, that's might be enough for us for now. thank you very much

@devversion
Copy link
Member

@krigton You are welcome. Thanks for the idea!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design This issue needs design work before implementing P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants