Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MdAutocompleteTrigger writeValue is asynchronous #3250

Open
nschipperbrainsmith opened this issue Feb 23, 2017 · 1 comment
Open

MdAutocompleteTrigger writeValue is asynchronous #3250

nschipperbrainsmith opened this issue Feb 23, 2017 · 1 comment
Labels
area: material/autocomplete P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@nschipperbrainsmith
Copy link

Bug, feature request, or proposal:

Request for change (RFC)

What is the expected behavior?

The MdAutocompleteTrigger writeValue ValueAccesor method should be synchronous.

What is the current behavior?

The MdAutocompleteTrigger writeValue ValueAccesor method is asynchronous.

What are the steps to reproduce?

Simply implement the autocomplete and try to detect a change being reflected within the view upon updating the formControl through setValue.
Doing this requires a setTimeout coupled with wrapping the body of the it statement with async(() => { ... }) when writing unit tests. If you wish to detect the change being relayed to the input value.

This is caused by the fact that (I assume) the writeValue wraps the _setTriggerValue method in a Promise.resolve(...): https://github.com/angular/material2/blob/master/src/lib/autocomplete/autocomplete-trigger.ts#L179

What is the use-case or motivation for changing an existing behavior?

The motivation for this RFC is the fact that it complicates testing. If their are valid reasons to make the autocomplete trigger asynchronous then that's fine, but the documentation should reflect this fact.

Which versions of Angular, Material, OS, browsers are affected?

2.0.0-beta.2
@jelbourn jelbourn changed the title MdAutocompleteTrigger is asynchronous MdAutocompleteTrigger writeValue is asynchronous May 1, 2017
@jelbourn
Copy link
Member

jelbourn commented May 1, 2017

@kara why is this async?

@jelbourn jelbourn assigned crisbeto and unassigned kara Jan 16, 2018
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Jan 27, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 27, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
9b566e1 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
@crisbeto crisbeto mentioned this issue Jan 27, 2018
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 3, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
09aeadc 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
jelbourn pushed a commit that referenced this issue Feb 12, 2018
@crisbeto @jelbourn
fix(autocomplete): make writeValue method synchronous
8193dac 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes #3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 11, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
76b923a 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 8, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
29e01ba 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 7, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
a983670 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 20, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
fb8edf1 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
mmalerba pushed a commit that referenced this issue May 24, 2018
@crisbeto @mmalerba
fix(autocomplete): make writeValue method synchronous
3e3bd31 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes #3250.
andrewseguin pushed a commit that referenced this issue Jun 7, 2018
@crisbeto @andrewseguin
fix(autocomplete): make writeValue method synchronous
3b7e7f4 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes #3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 29, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
15ab415 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 11, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
a9a04a3 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 16, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
7623122 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 24, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
28171de 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
jelbourn pushed a commit that referenced this issue Aug 25, 2018
@crisbeto @jelbourn
fix(autocomplete): make writeValue method synchronous
c63bae3 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes #3250.
vivian-hu-zz pushed a commit that referenced this issue Oct 3, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
093b4cb 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes #3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 23, 2018
@crisbeto
fix(autocomplete): make writeValue method synchronous
4714591 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 30, 2019
@crisbeto
fix(autocomplete): make writeValue method synchronous
09b2e79 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 8, 2019
@crisbeto
fix(autocomplete): make writeValue method synchronous
0748c00 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a `Promise.resolve` to defer rendering. This makes it easier to test and avoids potential race conditions. It seems like the reason it was added in the first place was to be able to handle components that have a preselected value through a `FormControl` as well as a custom `displayWith` function.

Fixes angular#3250.
@andrewseguin andrewseguin mentioned this issue Jul 20, 2020
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 12, 2020
@crisbeto
fix(material/autocomplete): make writeValue method synchronous
1493533 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a
`Promise.resolve` to defer rendering. This makes it easier to test and avoids potential
race conditions. It seems like the reason it was added in the first place was to be able
to handle components that have a preselected value through a `FormControl` as well
as a custom `displayWith` function.

Fixes angular#3250.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 2, 2022
@crisbeto
fix(material/autocomplete): make writeValue method synchronous
b9c748c 
Refactors the `MatAutocompleteTrigger.writeValue` method to avoid having to use a
`Promise.resolve` to defer rendering. This makes it easier to test and avoids potential
race conditions. It seems like the reason it was added in the first place was to be able
to handle components that have a preselected value through a `FormControl` as well
as a custom `displayWith` function.

Fixes angular#3250.
@mmalerba mmalerba removed the has pr label Dec 8, 2022
@daniel-sc daniel-sc mentioned this issue Oct 28, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: material/autocomplete P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/autocomplete): make writeValue method synchronous crisbeto/material2
6 participants
@jelbourn @nschipperbrainsmith @kara @crisbeto @mmalerba @andrewseguin