-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(Overlay): overlayOutsideClick triggered when clicking into shadowDOM within overlay #29241
Comments
Fixes that if an overlay contains a component using shadow DOM encapsulation, the clicks within it will be incorrectly picked up as outside clicks. Fixes angular#29241.
Fixes that if an overlay contains a component using shadow DOM encapsulation, the clicks within it will be incorrectly picked up as outside clicks. Fixes angular#29241.
@crisbeto Love that this is going to be fixed so fast. I planned to let this be my first open source contribution, though. Is there a way to show my willingness to provide a pull request for future issues? So that I can spend some time getting it ready - and getting familiar with the processes - before an experienced contributor does it with ease ;-) |
Ah sorry, I didn't notice in the description that you wanted to fix it. In general feel free to send out a PR directly for bug fixes. For larger features it's a good idea to open an issue first so we can discuss if it's something we would want to support. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Is this a regression?
The previous version in which this bug was not present was
No response
Description
When using a shadowDOM (e.g. with custom web components) within an overlay a click to that shadowDOM will trigger
overlayOutsideClick
.Can you confirm that this is unintended behavior?
If yes, I´ll try to provide a pull request to fix it.
Reproduction
StackBlitz link: https://stackblitz.com/edit/cdk-overlay-web-components-issue?file=src%2Fmain.ts
Steps to reproduce:
Expected Behavior
The click does not trigger
overlayOutsideClick
Actual Behavior
The click does trigger
overlayOutsideClick
Environment
The text was updated successfully, but these errors were encountered: