Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

live-announcer: allow custom live element #267

Closed
devversion opened this issue Apr 6, 2016 · 2 comments · Fixed by #273
Closed

live-announcer: allow custom live element #267

devversion opened this issue Apr 6, 2016 · 2 comments · Fixed by #273
Labels
Accessibility This issue is related to accessibility (a11y) feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@devversion
Copy link
Member

As mentioned in the originally PR, we'd like to have a possibility to use a custom live element.

There will be two possibilities:

  • Dependency Injection (OpaqueToken) for the Element
  • Public Service Method, to overwrite the Live Element.

I'm up to implemented that.
@jelbourn
Copy link
Member

jelbourn commented Apr 6, 2016

I think the OpaqueToken approach is good.

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) P5 The team acknowledges the request but does not plan to address it, it remains open for discussion help wanted The team would appreciate a PR from the community to address this issue feature This issue represents a new feature or feature request rather than a bug or bug fix labels Apr 6, 2016
devversion added a commit to devversion/material2 that referenced this issue Apr 7, 2016
@devversion
feat(live-announcer): add possibility to use a custom live element
7671712 
Fixes angular#267.
@devversion devversion mentioned this issue Apr 7, 2016
Merged
jelbourn pushed a commit that referenced this issue Apr 7, 2016
@devversion @jelbourn
feat(live-announcer): support using a provided live element (#273)
1a33a5b 
Fixes #267.
andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
@josephperrott @jelbourn
Focus page content after navigation for a11y. (angular#267)
b6da10c
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(live-announcer): add possibility to use a custom live element devversion/material2
2 participants
@jelbourn @devversion