Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangeDetectionStrategy.OnPush problem #2663

Closed
IliaIdakiev opened this issue Jan 15, 2017 · 3 comments · Fixed by #2894
Closed

ChangeDetectionStrategy.OnPush problem #2663

IliaIdakiev opened this issue Jan 15, 2017 · 3 comments · Fixed by #2894
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@IliaIdakiev
Copy link

IliaIdakiev commented Jan 15, 2017 •
edited
Loading

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When using ChangeDetectionStrategy.OnPush the md-select value is cleared when ngModel variable is set to null

What is the current behavior?

ngModel is null but md-select value persists

What are the steps to reproduce?

https://plnkr.co/edit/RGEWSXblOySdltKBku9o?p=preview

What is the use-case or motivation for changing an existing behavior?

Application Performance Optimization

Which versions of Angular, Material, OS, browsers are affected?

Angular v2.4.3
Angular Material v2.0.0-beta.1

Is there anything else we should know?

Maybe there are other controls not working with ChangeDetectionStrategy.OnPush
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jan 27, 2017
@web265p3 web265p3 mentioned this issue Feb 1, 2017
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 1, 2017
@crisbeto
fix(select): view not updating when using OnPush detection strategy
1dba3d3 
Fixes the select's view not being updated when the value is set through a component that has its change detection set to `OnPush`.

Fixes angular#2663.
Fixes angular#2269.
@crisbeto crisbeto added the has pr label Feb 1, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 1, 2017
@crisbeto
fix(select): view not updating when using OnPush detection strategy
930f55f 
Fixes the select's view not being updated when the value is set through a component that has its change detection set to `OnPush`.

Fixes angular#2663.
Fixes angular#2269.
@crisbeto crisbeto mentioned this issue Feb 1, 2017
Merged
tinayuangao pushed a commit that referenced this issue Feb 9, 2017
@crisbeto @tinayuangao
fix(select): view not updating when using OnPush detection strategy (#…
3bcb7c3 
…2894)

Fixes the select's view not being updated when the value is set through a component that has its change detection set to `OnPush`.

Fixes #2663.
Fixes #2269.
@farin99
Copy link

farin99 commented Mar 10, 2017

I still see this bug in beta.2 when using reactive forms.

@mjolk
Copy link

mjolk commented Mar 30, 2017

I'm seeing the same, beta.2/angular 4.0.0 reactive forms with ChangeDetectionStrategy.OnPush still exhibits this behaviour. Is there a temporary quickfix?

@mjolk mjolk mentioned this issue Mar 30, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): view not updating when using OnPush detection strategy crisbeto/material2
5 participants
@mjolk @farin99 @jelbourn @IliaIdakiev @crisbeto