Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(MatTabGroup): disablePagination property not disabling Pagination on MatTabGroup #26621

Closed
1 task
nathan-ortbals opened this issue Feb 14, 2023 · 1 comment · Fixed by #26647
Closed
1 task
Assignees
Labels
area: material/tabs P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@nathan-ortbals
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

When supplying the disablePagination input to the MatTabGroup component pagination is still present when shrinking the screen size. Likewise, supplying disablePagination in the MAT_TABS_CONFIG does not have an affect.

Reproduction

Stackblitz example

Steps to reproduce:

  1. Set the disablePagination property to true on a MatTabGroup component

  2. Shrink the size of the screen to force an overflow

  3. Set the disablePagination property to true on the MatTabsConfig object provided by the MAT_TABS_CONFIG injection token

  4. Shrink the size of the screen to force an overflow

Expected Behavior

The pagination buttons are not shown and the tab labels overflow the tab labels container.

image

Actual Behavior

The default pagination behavior is shown:

image

Environment

  • Angular: ^15.0.0
  • CDK/Material: ^15.0.0
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@nathan-ortbals nathan-ortbals added the needs triage This issue needs to be triaged by the team label Feb 14, 2023
@crisbeto crisbeto self-assigned this Feb 18, 2023
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/tabs and removed needs triage This issue needs to be triaged by the team labels Feb 18, 2023
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 18, 2023
The tab group wasn't passing the `disablePagination` input to the tab header so it wasn't being picked up.

Fixes angular#26621.
crisbeto added a commit that referenced this issue Feb 18, 2023
The tab group wasn't passing the `disablePagination` input to the tab header so it wasn't being picked up.

Fixes #26621.
crisbeto added a commit that referenced this issue Feb 18, 2023
The tab group wasn't passing the `disablePagination` input to the tab header so it wasn't being picked up.

Fixes #26621.

(cherry picked from commit 3c53deb)
crisbeto added a commit that referenced this issue Feb 18, 2023
The tab group wasn't passing the `disablePagination` input to the tab header so it wasn't being picked up.

Fixes #26621.

(cherry picked from commit 3c53deb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/tabs P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants