Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(checkbox): no persistent focus indicator if clicked on outer touch target padding #26486

Closed
1 task
RobinKamps opened this issue Jan 24, 2023 · 1 comment · Fixed by #26545
Closed
1 task

bug(checkbox): no persistent focus indicator if clicked on outer touch target padding #26486

RobinKamps opened this issue Jan 24, 2023 · 1 comment · Fixed by #26545
Assignees
@crisbeto
Labels
area: material/checkbox P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@RobinKamps
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

no persistent focus indicator if clicked on outer touch target padding... leading to non convenient keyboard (tab / shift+tab) controls.

checkbox-indicator

Reproduction

Steps to reproduce:

  1. https://material.angular.io/components/checkbox/overview
  2. click on the outer edges vs click on the center

Expected Behavior

  1. remaining focus indicator is set.
    or
  2. edges should not be clickable/no hover focus/no cursor.

Actual Behavior

no persistent focus indicator if clicked on outer touch target padding... leading to non convenient keyboard (tab / shift+tab) controls.

Environment

  • Angular: 15.1.1
  • CDK/Material: 15.1.1
  • Browser(s): all
  • Operating System (e.g. Windows, macOS, Ubuntu): all
@RobinKamps RobinKamps added the needs triage This issue needs to be triaged by the team label Jan 24, 2023
@crisbeto crisbeto self-assigned this Feb 1, 2023
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/checkbox and removed needs triage This issue needs to be triaged by the team labels Feb 1, 2023
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 1, 2023
@crisbeto
fix(material/checkbox): focus not moved to input when clicking on tou…
455bac8 
…ch target

Fixes that while we were toggling the checked state of a checkbox when its touch target is clicked, we weren't moving focus to the internal `input`.

Fixes angular#26486.
@crisbeto crisbeto mentioned this issue Feb 1, 2023
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 1, 2023
@crisbeto
fix(material/checkbox): focus not moved to input when clicking on tou…
99a5a49 
…ch target

Fixes that while we were toggling the checked state of a checkbox when its touch target is clicked, we weren't moving focus to the internal `input`.

Fixes angular#26486.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 2, 2023
@crisbeto
fix(material/checkbox): focus not moved to input when clicking on tou…
f03d40e 
…ch target

Fixes that while we were toggling the checked state of a checkbox when its touch target is clicked, we weren't moving focus to the internal `input`.

Fixes angular#26486.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 2, 2023
@crisbeto
fix(material/checkbox): focus not moved to input when clicking on tou…
8a16abf 
…ch target

Fixes that while we were toggling the checked state of a checkbox when its touch target is clicked, we weren't moving focus to the internal `input`.

Fixes angular#26486.
crisbeto added a commit that referenced this issue Feb 2, 2023
@crisbeto
fix(material/checkbox): focus not moved to input when clicking on tou…
48b4445 
…ch target (#26545)

Fixes that while we were toggling the checked state of a checkbox when its touch target is clicked, we weren't moving focus to the internal `input`.

Fixes #26486.
crisbeto added a commit that referenced this issue Feb 2, 2023
@crisbeto
fix(material/checkbox): focus not moved to input when clicking on tou…
621d175 
…ch target (#26545)

Fixes that while we were toggling the checked state of a checkbox when its touch target is clicked, we weren't moving focus to the internal `input`.

Fixes #26486.

(cherry picked from commit 48b4445)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/checkbox P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/checkbox): focus not moved to input when clicking on touch target crisbeto/material2
2 participants
@crisbeto @RobinKamps