Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example usage of MdDialog doesn't use md-dialog-content #2621

Closed
alexsapps opened this issue Jan 12, 2017 · 4 comments · Fixed by #3083
Closed

Example usage of MdDialog doesn't use md-dialog-content #2621

alexsapps opened this issue Jan 12, 2017 · 4 comments · Fixed by #3083
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@alexsapps
Copy link

This page gives an example of how to use MdDialog but it does not surround the dialog contents with ...
https://github.com/angular/material2/tree/master/src/lib/dialog

(I assume it is always required. The description of md-dialog-content is: "Scrollable content of the dialog." does not say that it's only required if scrolling is desired.)

@antonyRoberts
Copy link

It's not required, and you can implement scrolling without it by using CSS

@jelbourn
Copy link
Member

@crisbeto can you add an example for this once the examples are moved to the material2 repo in #2781?

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jan 27, 2017
@machtyn
Copy link

machtyn commented Jan 28, 2017

For reference:

        <p md-dialog-title>{{ title }}</p>
        <md-dialog-content>
          <p>{{ message }}</p>
        </md-dialog-content>
        <md-dialog-actions>
          <button md-raised-button md-dialog-close>{{closeText}}</button>
          <button type="button" md-raised-button *ngIf="enableNext"
              (click)="dialogRef.close(true)">{{nextText}}</button>
        </md-dialog-actions>

This snippet demonstrates several things:

  1. variables can be utilized to insert text of anything.
  2. How md-dialog-title is used (this is documented in the example)
  3. How md-dialog-content is used.
  4. How is used.

crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 13, 2017
Adds an example that shows how to use the various dialog content directives.

Fixes angular#2621.
andrewseguin pushed a commit that referenced this issue Feb 16, 2017
Adds an example that shows how to use the various dialog content directives.

Fixes #2621.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants