Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mat-slider): Mobile touch on edge causes non-cancelable touch event error #23820

Closed
cdestefano opened this issue Oct 22, 2021 · 1 comment · Fixed by #23823
Closed

bug(mat-slider): Mobile touch on edge causes non-cancelable touch event error #23820

cdestefano opened this issue Oct 22, 2021 · 1 comment · Fixed by #23823
Assignees
@crisbeto
Labels
area: material/slider P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@cdestefano
Copy link

Reproduction

StackBlitz
quick-demo-mat-slider

Steps to reproduce:

  1. View in mobile / responsive view
  2. Set initial slider position anywhere other than the end
  3. Click on the end of the slider

Expected Behavior

No console error is shown

Actual Behavior

A console error of

[Intervention] Ignored attempt to cancel a touchstart event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

It must be firing two click events at the same time, shouldn't it preventdefault on click?

Environment

  • Angular: 12.2.9
  • CDK/Material: 12.2.9
  • Browser(s): Chrome Version 95.0.4638.54
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows10
@cdestefano cdestefano added the needs triage This issue needs to be triaged by the team label Oct 22, 2021
@cdestefano cdestefano changed the title bug(mat-slider): Mobile touch on edge causes error for non-cancelable touch event to be thrown bug(mat-slider): Mobile touch on edge causes non-cancelable touch event error Oct 22, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 23, 2021
@crisbeto
fix(material/slider): avoid error on some touchstart events
5162563 
Fixes that the slider was throwing errors on some non-cancelable `touchstart` events.

Fixes angular#23820.
@crisbeto crisbeto mentioned this issue Oct 23, 2021
Merged
@crisbeto crisbeto self-assigned this Oct 23, 2021
@crisbeto crisbeto added area: material/slider has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Oct 23, 2021
andrewseguin pushed a commit that referenced this issue Jan 13, 2022
@crisbeto
fix(material/slider): avoid error on some touchstart events (#23823)
78db0d4 
Fixes that the slider was throwing errors on some non-cancelable `touchstart` events.

Fixes #23820.
andrewseguin pushed a commit that referenced this issue Jan 13, 2022
@crisbeto @andrewseguin
fix(material/slider): avoid error on some touchstart events (#23823)
7be61b6 
Fixes that the slider was throwing errors on some non-cancelable `touchstart` events.

Fixes #23820.

(cherry picked from commit 78db0d4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@crisbeto @forsti0506
fix(material/slider): avoid error on some touchstart events (angular#…
513bedc 
…23823)

Fixes that the slider was throwing errors on some non-cancelable `touchstart` events.

Fixes angular#23820.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/slider P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/slider): avoid error on some touchstart events crisbeto/material2
2 participants
@crisbeto @cdestefano