Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(MatRadio): Custom theme makes center circle invisible #23605

Closed
eolant opened this issue Sep 20, 2021 · 2 comments
Closed

bug(MatRadio): Custom theme makes center circle invisible #23605

eolant opened this issue Sep 20, 2021 · 2 comments

Comments

@eolant
Copy link

eolant commented Sep 20, 2021

Reproduction

Use StackBlitz to reproduce your issue:
https://stackblitz.com/edit/components-issue-7ijs5v?file=src%2Fstyles.scss

Steps to reproduce:

  1. Add a radio button
  2. Add custom theme with blue as primary palette

Expected Behavior

Radio button color is blue when selected

Actual Behavior

Radio button color middle circle is transparent

image

Environment

  • Angular: 12.2.5
  • CDK/Material: 12.2.5
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): MacOS
@eolant eolant added the needs triage This issue needs to be triaged by the team label Sep 20, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 21, 2021
Currently if an invalid hue is passed into `define-palette`, we silently emit nothing which can lead to confusion. These changes add an error to make it easier to debug.

Related to angular#23605.
@crisbeto
Copy link
Member

It's because the hues being passed into define-palette are incorrect. It works if you change this:

$mat-accent: mat.define-palette(mat.$orange-palette, a200, a100, a400);

To this:

$mat-accent: mt.define-palette(mat.$orange-palette, A200, A100, A400);

I've submitted #23612 to throw an error for cases like this one.

@crisbeto crisbeto added area: theming and removed needs triage This issue needs to be triaged by the team labels Sep 21, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants