Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - select not firing change event #2248

Closed
mmrath opened this issue Dec 16, 2016 · 3 comments · Fixed by #2458
Closed

Bug - select not firing change event #2248

mmrath opened this issue Dec 16, 2016 · 3 comments · Fixed by #2458
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix

Comments

@mmrath
Copy link

mmrath commented Dec 16, 2016

Bug, feature request, or proposal:

Bug

What is the expected behavior?

(change) should be fired when value of select is changed manually

What is the current behavior?

(change) is not fired

What are the steps to reproduce?

This plunker reproduces the issue
https://plnkr.co/edit/MyhgEgH4SzFJs7aoJtzy?p=preview

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, browsers are affected?

Latest all

Is there anything else we should know?
@kara kara added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Dec 20, 2016
@kara
Copy link
Contributor

kara commented Dec 20, 2016 •
edited
Loading

@mmrath There is no change event in the select's API at the moment. If you'd like to know when the value changes, you can use the standard valueChanges event from @angular/forms.

@Ploppy3
Copy link

Ploppy3 commented Dec 20, 2016

@kara Hello, does it support optgroup already?

@kara kara mentioned this issue Dec 28, 2016
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 29, 2016
@crisbeto
feat(select): emit change event
39b2365 
Adds an event to `md-select` that is emitted when the selected option has changed.

Fixes angular#2248.
@crisbeto crisbeto mentioned this issue Dec 29, 2016
Merged
@crisbeto crisbeto self-assigned this Dec 29, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 29, 2016
@crisbeto
feat(select): emit change event
ec89251 
Adds an event to `md-select` that is emitted when the selected option has changed.

Fixes angular#2248.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 29, 2016
@crisbeto
feat(select): emit change event
5105a89 
Adds an event to `md-select` that is emitted when the selected option has changed.

Fixes angular#2248.
@kara kara mentioned this issue Dec 29, 2016
Closed
tinayuangao pushed a commit that referenced this issue Jan 12, 2017
@crisbeto @tinayuangao
feat(select): emit change event (#2458)
e5bd15c 
* feat(select): emit change event

Adds an event to `md-select` that is emitted when the selected option has changed.

Fixes #2248.

* Separate the change event example from the ones that use the form directives.

* Remove leftover event listener.

* More leftovers.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(select): emit change event crisbeto/material2
4 participants
@mmrath @kara @crisbeto @Ploppy3