Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-snack-bar): use MDC-based button #21442

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix(material-experimental/mdc-snack-bar): use MDC-based button #21442

merged 1 commit into from
Mar 5, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 26, 2020 •
edited
Loading

Switches the MDC-based snack bar to use the MDC-based button. In general we should be using the MDC versions of components together, when possible.

Fixes #22024.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 26, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 26, 2020
@crisbeto crisbeto force-pushed the mdc-snack-bar-button branch from dfd2f92 to b0adc58 Compare December 26, 2020 16:06
@crisbeto crisbeto force-pushed the mdc-snack-bar-button branch from b0adc58 to 65b0e35 Compare January 9, 2021 15:02
@crisbeto crisbeto mentioned this pull request Feb 26, 2021
Closed
@annieyw annieyw added G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Feb 26, 2021
@annieyw
Copy link
Contributor

annieyw commented Feb 26, 2021

Fixes #22024

@crisbeto crisbeto force-pushed the mdc-snack-bar-button branch from 65b0e35 to 98f8531 Compare February 26, 2021 17:32
@crisbeto
fix(material-experimental/mdc-snack-bar): use MDC-based button
c4df183 
Switches the MDC-based snack bar to use the MDC-based button. In general we should
be using the MDC versions of components together, when possible.

Fixes angular#22024
@crisbeto crisbeto force-pushed the mdc-snack-bar-button branch from 98f8531 to c4df183 Compare February 26, 2021 17:34
@annieyw annieyw requested a review from jelbourn February 26, 2021 17:39
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Mar 1, 2021
@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 5, 2021
@annieyw annieyw merged commit 9f879b2 into angular:master Mar 5, 2021
This was referenced Mar 17, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mdc-snack-bar): Still uses legacy mat-button
3 participants
@crisbeto @annieyw @andrewseguin