Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar height should adjust based on @media #2085

Closed
code-tree opened this issue Dec 6, 2016 · 7 comments · Fixed by #2157
Closed

Toolbar height should adjust based on @media #2085

code-tree opened this issue Dec 6, 2016 · 7 comments · Fixed by #2157
Assignees
@devversion

Comments

@code-tree
Copy link
Contributor

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Toolbar height follows spec

Mobile Landscape: 48dp
Mobile Portrait: 56dp
Tablet/Desktop: 64dp

What is the current behavior?

Toolbar height is static at 64px.

What are the steps to reproduce?

n/a

What is the use-case or motivation for changing an existing behavior?

Follow spec

Which versions of Angular, Material, OS, browsers are affected?

Material 2.0.0-alpha.10

Is there anything else we should know?

This should probably be implemented using CSS @media?
@devversion
Copy link
Member

@jelbourn Should we implement that? From what I remember we decided to let the user take care of it?

@code-tree
Copy link
Contributor Author

I'm fine with that, as I've already made my own implementation

@jelbourn
Copy link
Member

jelbourn commented Dec 6, 2016

@devversion I'd be okay with making it responsive per the spec.

@devversion
Copy link
Member

@jelbourn I'd rather make it optional like having an attribute like md-responsive, because I think it would confuse users.

@jelbourn
Copy link
Member

jelbourn commented Dec 6, 2016

Being responsive by default seems good to me, though, since users can always explicitly set the height to override the default behavior.

@devversion
Copy link
Member

Ah yeah makes sense. I'm going to create a PR to change it.

@devversion devversion self-assigned this Dec 6, 2016
devversion added a commit to devversion/material2 that referenced this issue Dec 10, 2016
@devversion
update(toolbar): add responsive heights as per spec
340f5fa 
* Adds media queries to dynamically adjust the height of the toolbar according to the specifications.
  https://material.google.com/layout/structure.html#structure-app-bar

Closes angular#2085.
@devversion devversion mentioned this issue Dec 10, 2016
Merged
jelbourn pushed a commit that referenced this issue Dec 14, 2016
@devversion @jelbourn
update(toolbar): add responsive heights as per spec (#2157)
78d54fc 
* update(toolbar): add responsive heights as per spec

* Adds media queries to dynamically adjust the height of the toolbar according to the specifications.
  https://material.google.com/layout/structure.html#structure-app-bar

Closes #2085.

* Remove extra blank line
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update(toolbar): add responsive heights as per spec devversion/material2
3 participants
@jelbourn @devversion @code-tree