Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MENU_PANEL_TOP_PADDING does not allow customization #16167

Closed
rcketscientist opened this issue May 31, 2019 · 1 comment · Fixed by #16169
Closed

MENU_PANEL_TOP_PADDING does not allow customization #16167

rcketscientist opened this issue May 31, 2019 · 1 comment · Fixed by #16169
Assignees
@crisbeto
Labels
area: material/menu P4 A relatively minor issue that is not relevant to core functions

Comments

@rcketscientist
Copy link

Expected Behavior

What behavior were you expecting to see?

Ability to define menu padding.

Actual Behavior

What behavior did you actually see?

Menus shift by 8px, regardless of how much padding they actually have.

components/src/material/menu/menu-trigger.ts

Line 62 in 612a738

export const MENU_PANEL_TOP_PADDING = 8;

@crisbeto crisbeto self-assigned this May 31, 2019
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels May 31, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue May 31, 2019
@crisbeto
fix(menu): account for menu padding different from the default
18779fd 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
@crisbeto crisbeto mentioned this issue May 31, 2019
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 20, 2019
@crisbeto
fix(menu): account for menu padding different from the default
3a495f9 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 4, 2019
@crisbeto
fix(menu): account for menu padding different from the default
34cd5dd 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
jelbourn pushed a commit that referenced this issue Sep 6, 2019
@crisbeto @jelbourn
fix(menu): account for menu padding different from the default
eeecead 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes #16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
cef9436 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
e8dbedb 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
d8772ef 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
9680f9b 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
21ae4ec 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
3c10ad9 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
55c7726 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
77e98e8 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
6965f95 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the default
153f3ec 
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
crisbeto added a commit that referenced this issue Feb 27, 2022
@crisbeto
fix(material/menu): account for menu padding different from the defau…
4429352 
…lt (#16169)

Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes #16167.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@crisbeto @forsti0506
fix(material/menu): account for menu padding different from the defau…
cf54d44 
…lt (angular#16169)

Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.

Fixes angular#16167.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/menu P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/menu): account for menu padding different from the default crisbeto/material2
3 participants
@rcketscientist @crisbeto @andrewseguin