-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display: flex
on .md-tab-body-wrapper
is causing problems
#1416
Comments
Yeah, I would consider this a bug. |
I don't believe this is a problem anymore. There have been a good amount of changes made recently to how tab content is created. Here's an example of tabs with simple text bodies that span the width of the tab group. Please reopen if you can reproduce the issue. |
What @Salma7amed said still is not fixed #1416 (comment) there are |
@fxck Can you please reopen this? This is still an issue as your plnkr clearly demonstrates. |
Don't have the option. |
@fxck Ah ok. |
Just to make sure I'm capturing the right issue here, I'll run through what has been discussed. This issue began as the body wrapper not spanning the width of the tabs. That appears fixed. The second issue presented is that dropdown menus do not overflow correctly. It appears that is because the menu overlay was placed within the tab. MdSelect does not have this issue since the overlay is placed on the page body. The third issue seems to be that the md-card does not show shadows when the card's width and height matches the width and height of the tab. I'm not sure I understand the requested behavior. Do you want the shadows to extend beyond the bottom and sides of the tab? Here's a plunker we can use as a template for this discussion: https://plnkr.co/edit/Zf4mLF1iTiosrmMo0wkr?p=preview Note that my goal here is to close this issue after we figured out if a new issue should be created based on this discussion. This thread has already diverted away from the original issue. |
@andrewseguin I agree. I think new issues should be created.
Thanks for explaining this. I realize now why part of my content in the tab was not displaying properly. With the current bug for MdSelect #2124 I had to create a hybrid approach of using polymer components with angular 2. Alas this caused me problems since the paper-dropdown-menu doesn't put the overlay on the body but within its parent component. Thus with an overflow of hidden I didn't see all my options. I don't really know a good work around for this right now except for changing the encapsulation in my parent component to None so I can modify the tab styles to not overflow. |
Encapsulation set to None is one option, there are two others.
Closing the issue now since there is no activity, but please feel free to open it back up if there are any remaining issues that cannot be resolved. Just please use the issue template, it helps us tremendously :) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
It causes this..
..any inner content is only as wide as need be.. which is not something you usually want. Is there any particular reason for that
flex
? Can't it be justblock
, which would solve it?The text was updated successfully, but these errors were encountered: