Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display: flex on .md-tab-body-wrapper is causing problems #1416

Closed
fxck opened this issue Oct 3, 2016 · 12 comments
Closed

display: flex on .md-tab-body-wrapper is causing problems #1416

fxck opened this issue Oct 3, 2016 · 12 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@fxck
Copy link
Contributor

fxck commented Oct 3, 2016

It causes this..

image

..any inner content is only as wide as need be.. which is not something you usually want. Is there any particular reason for that flex? Can't it be just block, which would solve it?

@jelbourn
Copy link
Member

jelbourn commented Oct 5, 2016

Yeah, I would consider this a bug.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Oct 5, 2016
@Salma7amed
Copy link

the md-tab-body-wrapper and md-tab-body overflow is causing a problem. It hides the dropdown menu.
screen shot 2016-10-12 at 06 47 43

@andrewseguin andrewseguin self-assigned this Nov 3, 2016
@andrewseguin
Copy link
Contributor

I don't believe this is a problem anymore. There have been a good amount of changes made recently to how tab content is created.

Here's an example of tabs with simple text bodies that span the width of the tab group.
http://plnkr.co/edit/pEqGa6YwmTE2fxBDEGJf?p=preview

Please reopen if you can reproduce the issue.

@fxck
Copy link
Contributor Author

fxck commented Nov 14, 2016

What @Salma7amed said still is not fixed #1416 (comment) there are overflows set that are causing the content to be clipped, for example when you use md-card inside a tab content, shadows are clipped.

@andrewseguin

@fxck
Copy link
Contributor Author

fxck commented Nov 14, 2016

@JacobBrandt
Copy link

@fxck Can you please reopen this? This is still an issue as your plnkr clearly demonstrates.

@fxck
Copy link
Contributor Author

fxck commented Mar 10, 2017

Don't have the option.

@JacobBrandt
Copy link

@fxck Ah ok.
I'm going to tag @andrewseguin since he closed it. Hopefully he has the power to open it for you.

@andrewseguin
Copy link
Contributor

andrewseguin commented Mar 10, 2017

Just to make sure I'm capturing the right issue here, I'll run through what has been discussed.

This issue began as the body wrapper not spanning the width of the tabs. That appears fixed.

The second issue presented is that dropdown menus do not overflow correctly. It appears that is because the menu overlay was placed within the tab. MdSelect does not have this issue since the overlay is placed on the page body.

The third issue seems to be that the md-card does not show shadows when the card's width and height matches the width and height of the tab. I'm not sure I understand the requested behavior. Do you want the shadows to extend beyond the bottom and sides of the tab?

Here's a plunker we can use as a template for this discussion: https://plnkr.co/edit/Zf4mLF1iTiosrmMo0wkr?p=preview

Note that my goal here is to close this issue after we figured out if a new issue should be created based on this discussion. This thread has already diverted away from the original issue.

@andrewseguin andrewseguin reopened this Mar 10, 2017
@JacobBrandt
Copy link

JacobBrandt commented Mar 10, 2017

@andrewseguin I agree. I think new issues should be created.

MdSelect does not have this issue since the overlay is placed on the page body.

Thanks for explaining this. I realize now why part of my content in the tab was not displaying properly. With the current bug for MdSelect #2124 I had to create a hybrid approach of using polymer components with angular 2. Alas this caused me problems since the paper-dropdown-menu doesn't put the overlay on the body but within its parent component. Thus with an overflow of hidden I didn't see all my options. I don't really know a good work around for this right now except for changing the encapsulation in my parent component to None so I can modify the tab styles to not overflow.

@andrewseguin
Copy link
Contributor

Encapsulation set to None is one option, there are two others.

  1. Use /deep/ in your CSS selectors
  2. Use a global style sheet that is loaded outside of Angular (not a part of any styleUrls).

Closing the issue now since there is no activity, but please feel free to open it back up if there are any remaining issues that cannot be resolved. Just please use the issue template, it helps us tremendously :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

5 participants