Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature for mat-paginator; [disableOptionCentering] #13646

Closed
mibrezovec opened this issue Oct 17, 2018 · 8 comments · Fixed by #13705
Closed

Feature for mat-paginator; [disableOptionCentering] #13646

mibrezovec opened this issue Oct 17, 2018 · 8 comments · Fixed by #13705
Assignees
Labels
area: material/paginator feature This issue represents a new feature or feature request rather than a bug or bug fix needs: discussion Further discussion with the team is needed before proceeding P4 A relatively minor issue that is not relevant to core functions

Comments

@mibrezovec
Copy link

Bug, feature request, or proposal:

As any mat-select, mat-select inside the mat-paginator should be able to use [disableOptionCentering].

What is the expected behavior?

Something on the lines of
<mat-paginator [disableOptionCentering]="true" [length]="pageLength" </mat-paginator>

Adding the [disableOptionCentering] should be possible and working as intended (like with any other mat-select). See mat-select API for detailed explanation.

What is the current behavior?

It's not possible. mat-paginator API

What are the steps to reproduce?

https://material.angular.io/components/paginator/overview

Select options from the "Items per page", the chosen option will be in the "dropdown" center.

What is the use-case or motivation for changing an existing behavior?

It should be posibble to use [disableOptionCentering] with any mat-selects, even if in a paginator.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

All that support mat-paginators I guess.

Is there anything else we should know?

Nope.

@crisbeto
Copy link
Member

crisbeto commented Oct 17, 2018

This should be easy enough to add, but I'm not sure how practical it would be to continue doing it. Eventually we'd end up proxying every single input on mat-select.

@krivkoo
Copy link

krivkoo commented Oct 19, 2018

Hello, @crisbeto, @mibrezovec ,
Is this issue still unassigned ? I'd like to take this on me

Best regards

Matthew

@mibrezovec
Copy link
Author

Afaik, not assigned atm, you can take it @krivkoo
Thank you!

@krivkoo
Copy link

krivkoo commented Oct 19, 2018

Will you assign it to me or will I do it? @mibrezovec

@mibrezovec
Copy link
Author

Please feel free to do it yourself, I am new here and uncertain if I can assign you if I'm not an admin. @krivkoo

@josephperrott josephperrott added feature This issue represents a new feature or feature request rather than a bug or bug fix discussion labels Oct 19, 2018
@crisbeto crisbeto self-assigned this Oct 20, 2018
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Oct 20, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 20, 2018
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 24, 2018
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
vivian-hu-zz pushed a commit that referenced this issue Nov 6, 2018
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes #13646.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 31, 2019
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 6, 2019
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 13, 2019
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 18, 2019
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
@mmalerba mmalerba added needs: discussion Further discussion with the team is needed before proceeding and removed discussion labels Mar 3, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 8, 2020
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 20, 2020
Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 1, 2022

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 22, 2022

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
…lect

Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
…lect

Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
…lect

Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
crisbeto added a commit that referenced this issue Feb 26, 2022
…lect (#13705)

Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes #13646.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
…lect (angular#13705)

Since we hide the underlying `MatSelect` inside the `MatPaginator`, the user doesn't have the ability to configure some of the inputs. These changes introduce an input that proxy some of the supported properties to the select.

Fixes angular#13646.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/paginator feature This issue represents a new feature or feature request rather than a bug or bug fix needs: discussion Further discussion with the team is needed before proceeding P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants