Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatIconRegistry request: allow registering multiple default font set classes #10471

Closed
kuhnroyal opened this issue Mar 18, 2018 · 1 comment · Fixed by #10484
Closed

MatIconRegistry request: allow registering multiple default font set classes #10471

kuhnroyal opened this issue Mar 18, 2018 · 1 comment · Fixed by #10484
Assignees
@crisbeto
Labels
area: material/icon P4 A relatively minor issue that is not relevant to core functions

Comments

@kuhnroyal
Copy link

Bug, feature request, or proposal:

Request

What is the expected behavior?

MatIconRegistry.setDefaultFontSetClass to accept multiple css classes

What is the current behavior?

MatIconRegistry.setDefaultFontSetClass accepts only one class

What is the use-case or motivation for changing an existing behavior?

Some font sets require multiple classes that are tiresome to repeat on all icons.

For example: MatIconRegistry.setDefaultFontSetClasses("mdi", "mdi-48px") would be nice to have.
@crisbeto crisbeto self-assigned this Mar 19, 2018
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Mar 19, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 19, 2018
@crisbeto
feat(icon): allow multiple classes in setDefaultFontSetClass
fb1dda9 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
@crisbeto crisbeto mentioned this issue Mar 19, 2018
Merged
mmalerba pushed a commit that referenced this issue Apr 18, 2018
@crisbeto @mmalerba
feat(icon): allow multiple classes in setDefaultFontSetClass
b833b06 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes #10471.
josephperrott pushed a commit that referenced this issue May 30, 2018
@crisbeto @josephperrott
feat(icon): allow multiple classes in setDefaultFontSetClass
0cc533d 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes #10471.
andrewseguin pushed a commit that referenced this issue Jun 7, 2018
@crisbeto @andrewseguin
feat(icon): allow multiple classes in setDefaultFontSetClass
931127d 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes #10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 16, 2018
@crisbeto
feat(icon): allow multiple classes in setDefaultFontSetClass
d36d541 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
josephperrott pushed a commit that referenced this issue Aug 7, 2018
@crisbeto @josephperrott
feat(icon): allow multiple classes in setDefaultFontSetClass
3df3a61 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes #10471.
jelbourn pushed a commit that referenced this issue Aug 23, 2018
@crisbeto @jelbourn
feat(icon): allow multiple classes in setDefaultFontSetClass
77026be 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes #10471.
jelbourn pushed a commit that referenced this issue Aug 25, 2018
@crisbeto @jelbourn
feat(icon): allow multiple classes in setDefaultFontSetClass
a644e8f 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes #10471.
vivian-hu-zz pushed a commit that referenced this issue Oct 3, 2018
@crisbeto
feat(icon): allow multiple classes in setDefaultFontSetClass
d606fa4 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes #10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 29, 2019
@crisbeto
feat(icon): allow multiple classes in setDefaultFontSetClass
2bcc9b2 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 1, 2019
@crisbeto
feat(icon): allow multiple classes in setDefaultFontSetClass
cdb8286 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
@crisbeto
feat(material/icon): allow multiple classes in setDefaultFontSetClass
751e6f5 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
@crisbeto
feat(material/icon): allow multiple classes in setDefaultFontSetClass
de190fb 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
@crisbeto
feat(material/icon): allow multiple classes in setDefaultFontSetClass
408bf53 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
@crisbeto
feat(material/icon): allow multiple classes in setDefaultFontSetClass
47cef10 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
@crisbeto
feat(material/icon): allow multiple classes in setDefaultFontSetClass
e9138e0 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2022
@crisbeto
feat(material/icon): allow multiple classes in setDefaultFontSetClass
5e9620e 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
crisbeto added a commit that referenced this issue Feb 28, 2022
@crisbeto
feat(material/icon): allow multiple classes in setDefaultFontSetClass (…
6c7cc8a 
…#10484)

Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes #10471.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@crisbeto @forsti0506
feat(material/icon): allow multiple classes in setDefaultFontSetClass (…
f15362b 
…angular#10484)

Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/icon P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(material/icon): allow multiple classes in setDefaultFontSetClass crisbeto/material2
3 participants
@kuhnroyal @crisbeto @andrewseguin