Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dense lists avatar size doesn't follow the guidelines #10019

Closed
philip-firstorder opened this issue Feb 19, 2018 · 2 comments · Fixed by #10028
Closed

Dense lists avatar size doesn't follow the guidelines #10019

philip-firstorder opened this issue Feb 19, 2018 · 2 comments · Fixed by #10028
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@philip-firstorder
Copy link

Bug, feature request, or proposal:

Dense lists avatar size doesn't follow the guidelines, it should be 36px in height and width.

components-lists-keylines-two10-dense
components-lists-keylines-two10

What is the expected behavior?

Dense list avatar size should be 36px;

What is the current behavior?

In material2/src/lib/list/list.scss
$mat-list-avatar-size = 40; For both normal and dense lists.

What are the steps to reproduce?

Dense list to the right should have smaller avatars.
https://tina-material-tree.firebaseapp.com/list

What is the use-case or motivation for changing an existing behavior?

Avatar size should follow the guidelines.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/core": "^5.2.5",
"@angular/material": "^5.2.1",

Is there anything else we should know?
@crisbeto crisbeto self-assigned this Feb 19, 2018
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Feb 19, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 19, 2018
@crisbeto
fix(list): align avatar size in dense list with spec
40c7657 
* Fixes the dense list avatar being slightly larger than the spec.
* Removes an unnecessary setter from the `MatListItem` class.

Fixes angular#10019.
@crisbeto crisbeto mentioned this issue Feb 19, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 20, 2018
@crisbeto
fix(list): align avatar size in dense list with spec
0fa296b 
* Fixes the dense list avatar being slightly larger than the spec.
* Removes an unnecessary setter from the `MatListItem` class.

Fixes angular#10019.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 20, 2018
@crisbeto
fix(list): align avatar size in dense list with spec
9abd74f 
* Fixes the dense list avatar being slightly larger than the spec.
* Removes an unnecessary setter from the `MatListItem` class.

Fixes angular#10019.
jelbourn pushed a commit that referenced this issue Feb 26, 2018
@crisbeto @jelbourn
fix(list): align avatar size in dense list with spec (#10028)
d4a4f61 
* Fixes the dense list avatar being slightly larger than the spec.
* Removes an unnecessary setter from the `MatListItem` class.

Fixes #10019.
mmalerba pushed a commit to mmalerba/components that referenced this issue Feb 26, 2018
@crisbeto @mmalerba
fix(list): align avatar size in dense list with spec (angular#10028)
eff97b2 
* Fixes the dense list avatar being slightly larger than the spec.
* Removes an unnecessary setter from the `MatListItem` class.

Fixes angular#10019.
jelbourn pushed a commit to jelbourn/components that referenced this issue Feb 27, 2018
@crisbeto @jelbourn
fix(list): align avatar size in dense list with spec (angular#10028)
7d81b6f 
* Fixes the dense list avatar being slightly larger than the spec.
* Removes an unnecessary setter from the `MatListItem` class.

Fixes angular#10019.
@philip-firstorder
Copy link
Author

philip-firstorder commented Feb 14, 2019 •
edited
Loading

The height should remain 48px when using mat-nav-list with mat-list-icon.
https://material.io/design/components/navigation-drawer.html#specs

@crisbeto Now because of the mat-list-item-with-avatar it gets set to 56px, which is wrong.
https://angular-gqqput.stackblitz.io

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(list): align avatar size in dense list with spec crisbeto/material2
2 participants
@crisbeto @philip-firstorder