Skip to content

Commit

Permalink
fix(select): not trimming long labels
Browse files Browse the repository at this point in the history
* Fixes long text not being trimmed inside of `md-option`, because the element is a flex container. Switches it to `display: block` and uses `line-height` to center the text.
* Fixes the selected value not being trimmed, because the element doesn't have a defined width.

Fixes #2440.
  • Loading branch information
crisbeto committed Dec 28, 2016
1 parent dccbe41 commit e367278
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/demo-app/select/select-demo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class SelectDemo {

drinks = [
{value: 'coke-0', viewValue: 'Coke'},
{value: 'sprite-1', viewValue: 'Sprite'},
{value: 'long-name-1', viewValue: 'Decaf Chocolate Brownie Vanilla Gingerbread Frappuccino'},
{value: 'water-2', viewValue: 'Water'},
{value: 'pepper-3', viewValue: 'Dr. Pepper'},
{value: 'coffee-4', viewValue: 'Coffee'},
Expand Down
6 changes: 3 additions & 3 deletions src/lib/core/style/_menu-common.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ $md-menu-side-padding: 16px !default;
@mixin md-menu-item-base() {
@include md-truncate-line();

display: flex;
flex-direction: row;
align-items: center;
// Needs to be a block for the ellipsis to work.
display: block;
line-height: $md-menu-item-height;
height: $md-menu-item-height;
padding: 0 $md-menu-side-padding;

Expand Down
3 changes: 2 additions & 1 deletion src/lib/select/select.scss
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ md-select {
}

.md-select-value {
position: absolute;
@include md-truncate-line();
position: absolute;
max-width: calc(100% - #{$md-select-arrow-size * 2});

// Firefox and some versions of IE incorrectly keep absolutely
// positioned children of flex containers in the flex flow when calculating
Expand Down

0 comments on commit e367278

Please sign in to comment.