-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(material/paginator): remove TypeScript mixin usages
Replaces the final usage of TypeScript mixins in the paginator.
- Loading branch information
Showing
2 changed files
with
16 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e13ece1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shoudn't be there
this._initializedStream.complete();
after
this._initializedStream.next();
?
because current behaviour is different as it was before, this is probably breaking change
in mixinInitialized is comment
/** Emits and completes the subscriber stream (should only emit once). */
e13ece1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a
_initializedStream.complete
inngOnDestroy
. Emitting and then completely it immediately seemed a bit weird and none of our internal tests were affected by it so I figured that it's not particularly breaking.e13ece1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using something like this
concat(this.paginator.initialized, ......)
when
this.paginator.initialized
doesn't complete, it stucks, calling complete inngOnDestroy
is too late in this casebut ok, probably I should change my code...