Skip to content

Commit

Permalink
chore: fix detach typos in overlay and portal (#1840)
Browse files Browse the repository at this point in the history
  • Loading branch information
devversion authored and kara committed Nov 15, 2016
1 parent 83de14f commit 607de8f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/lib/core/overlay/overlay-ref.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ export class OverlayRef implements PortalHost {
}

detach(): Promise<any> {
this._detatchBackdrop();
this._detachBackdrop();
return this._portalHost.detach();
}

dispose(): void {
this._detatchBackdrop();
this._detachBackdrop();
this._portalHost.dispose();
}

Expand Down Expand Up @@ -101,7 +101,7 @@ export class OverlayRef implements PortalHost {
}

/** Detaches the backdrop (if any) associated with the overlay. */
private _detatchBackdrop(): void {
private _detachBackdrop(): void {
let backdropToDetach = this._backdropElement;

if (backdropToDetach) {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/core/portal/portal-directives.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class PortalHostDirective extends BasePortalHost implements OnDestroy {
return new Map<string, any>();
}

/** Detatches the currently attached Portal (if there is one) and attaches the given Portal. */
/** Detaches the currently attached Portal (if there is one) and attaches the given Portal. */
private _replaceAttachedPortal(p: Portal<any>): void {
if (this.hasAttached()) {
this.detach();
Expand Down
2 changes: 1 addition & 1 deletion src/lib/core/portal/portal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export abstract class Portal<T> {

/**
* Sets the PortalHost reference without performing `attach()`. This is used directly by
* the PortalHost when it is performing an `attach()` or `detatch()`.
* the PortalHost when it is performing an `attach()` or `detach()`.
*/
setAttachedHost(host: PortalHost) {
this._attachedHost = host;
Expand Down

0 comments on commit 607de8f

Please sign in to comment.