Skip to content

Commit

Permalink
build: run commit message check after other lint checks (#22208)
Browse files Browse the repository at this point in the history
We recently had some lint failures slip into the main branch, because they had both
commit message failures and other lint failures. The problem was that we sometimes
ignore commit message failures since they can be fixed by the caretaker, but if the commit
check fails, it prevents any other the other lint checks from running.

These changes move the commit message check to be last in the `lint` job so that if it fails,
we know that everything else is in a mergeable state.

(cherry picked from commit 58118ec)
  • Loading branch information
crisbeto authored and mmalerba committed Mar 15, 2021
1 parent 9e39eda commit 56851bf
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,13 @@ jobs:
yarn check-entry-point-setup $(bazel info bazel-bin)/entry_points_manifest.json
- run: yarn ng-dev format changed --check << pipeline.git.base_revision >>
- run: yarn ownerslint
- run: yarn check-mdc-tests
- run: yarn stylelint
- run: yarn tslint
- run: yarn -s ts-circular-deps:check
- run: yarn check-mdc-exports
# Should be last so that it doesn't prevent the other lint checks from running.
- run:
name: Check Commit Message (PR Only)
# Only run the commit message checks on pull requests since we can't do
Expand All @@ -361,12 +368,6 @@ jobs:
if [ -n "$CIRCLE_PR_NUMBER" ]; then
yarn ng-dev commit-message validate-range --range $CI_COMMIT_RANGE
fi
- run: yarn ownerslint
- run: yarn check-mdc-tests
- run: yarn stylelint
- run: yarn tslint
- run: yarn -s ts-circular-deps:check
- run: yarn check-mdc-exports
- *slack_notify_on_failure
- *save_cache
Expand Down

0 comments on commit 56851bf

Please sign in to comment.