Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted permission check #2763

Closed
wants to merge 1 commit into from
Closed

Conversation

nmggithub
Copy link

Since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here

Checklist

Description

As explained in the commit: since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here.

Since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here
@jamesdaniels
Copy link
Member

The problem is AngularFire's API has always expected the developer to request permission manually, so in order to not break semver & take the peer we gated it. We can consider dropping this at the next major version, not before.

@nmggithub
Copy link
Author

The problem is AngularFire's API has always expected the developer to request permission manually, so in order to not break semver & take the peer we gated it. We can consider dropping this at the next major version, not before.

Good to know. Looking forward to it.

@jamesdaniels
Copy link
Member

Hey there, we have a new major of AngularFire coming up, but we've changed directions and are shipping the same API as Firebase JS SDK. Thanks for the contribution but I'm going to close this as it's no longer relevant to the new design #2770. Looking forward to any ideas you might have to improve the library in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants