fix(compiler-cli): support JIT transforms before other transforms modifying classes #57262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifying classes Similar to a previous fix that intended to make the JIT transforms compatible with pre-transforms like e.g. Tsickle, we need to solve an additional issue where the class properties are synthetic and result in an `getSourceFile() => undefined` invocation that breaks the import insertion, causing errors like: ``` TypeError: Cannot read properties of undefined (reading 'fileName') ```
devversion
added
action: review
JoostK
approved these changes
Aug 5, 2024
devversion
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Aug 5, 2024
…ifying classes (#57262) Similar to a previous fix that intended to make the JIT transforms compatible with pre-transforms like e.g. Tsickle, we need to solve an additional issue where the class properties are synthetic and result in an `getSourceFile() => undefined` invocation that breaks the import insertion, causing errors like: ``` TypeError: Cannot read properties of undefined (reading 'fileName') ``` PR Close #57262
|
This PR was merged into the repository by commit e2259c7. The changes were merged into the following branches: main, 18.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
and-oli
pushed a commit
to and-oli/angular
that referenced
this pull request
Sep 30, 2024
…ifying classes (angular#57262) Similar to a previous fix that intended to make the JIT transforms compatible with pre-transforms like e.g. Tsickle, we need to solve an additional issue where the class properties are synthetic and result in an `getSourceFile() => undefined` invocation that breaks the import insertion, causing errors like: ``` TypeError: Cannot read properties of undefined (reading 'fileName') ``` PR Close angular#57262
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to a previous fix that intended to make the JIT transforms compatible with pre-transforms like e.g. Tsickle, we need to solve an additional issue where the class properties are synthetic and result in an
getSourceFile() => undefinedinvocation that breaks the import insertion, causing errors like: