fix(language-service): avoid generating TS suggestion diagnostics for templates #56241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… templates Angular's template files are not valid TypeScript. Attempting to get suggestion diagnostics from the underlying TypeScript language service will result in a large amount of false positives. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for suggestions.
dylhunn
approved these changes
Jun 3, 2024
thePunderWoman
added
the
area: language-service
clydin
added
action: merge
|
Github won't remove additional reviewer. Pullapprove is green. |
thePunderWoman
pushed a commit
that referenced
this pull request
Aug 2, 2024
… templates (#56241) Angular's template files are not valid TypeScript. Attempting to get suggestion diagnostics from the underlying TypeScript language service will result in a large amount of false positives. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for suggestions. PR Close #56241
|
This PR was merged into the repository by commit 4bb9d0f. The changes were merged into the following branches: main, 18.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
and-oli
pushed a commit
to and-oli/angular
that referenced
this pull request
Sep 30, 2024
… templates (angular#56241) Angular's template files are not valid TypeScript. Attempting to get suggestion diagnostics from the underlying TypeScript language service will result in a large amount of false positives. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for suggestions. PR Close angular#56241
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular's template files are not valid TypeScript. Attempting to get suggestion diagnostics from the underlying TypeScript language service will result in a large amount of false positives. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for suggestions.