fix(bazel): enable dts bundling for Ivy packages #42728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
area: build & ci
alan-agius4
commented
Jul 1, 2021
goldens/public-api/common/common.md
Outdated
| @@ -262,7 +262,7 @@ export class KeyValuePipe implements PipeTransform { | |||
| } | |||
|
|
|||
| // @public | |||
| export class Location { | |||
| class Location_2 { | |||
There was a problem hiding this comment.
API extractor renames these to avoid clashes with globals variables.
alan-agius4
added
the
area: compiler
alan-agius4
added
the
action: review
petebacondarwin
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
LGTM
Can you clarify the last commit message a bit? I found it a bit confusing.
Currently it says:
fix(compiler-cli): support reflecting local modules
With the recent change to enable Ivy DTS bundling, will convert local namespace imports to local modules such as the below;
```ts
declare namespace i1 {
export {
RouterOutletContract,
RouterOutlet
}
}
export declare class RouterModule {
constructor(guard: any, router: Router);
static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>;
}
```
With this change we amend `reflectTypeEntityToDeclaration` to support this.
I believe that these "local modules" are what used to be called "internal modules" and are actually now referred to simply as "namespaces". This is compared to "external modules" which are now referred to as just "modules". See https://www.typescriptlang.org/docs/handbook/namespaces.html.
I think it would be helpful to explain the background motivation for this change. I.e that when the definition of a type is in a bundled d.ts file, then what were originally namespaced imports become namespace declarations within this file. And therefore this commit adds support for reflecting types that are defined in such namespace declarations.
|
@petebacondarwin, commit message updated. |
Perfect! Thanks. |
devversion
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
LGTM. Worth capturing here that 56bd21d has been implemented to allow for this update to happen (due to the new alias exports being generated)
IgorMinar
approved these changes
Jul 2, 2021
JoostK
approved these changes
Jul 2, 2021
pullapprove
bot
requested review from
AndrewKushnir,
jelbourn and
petebacondarwin
pullapprove
bot
requested review from
AndrewKushnir,
atscott,
jessicajaniuk and
zarend
We can now allow Renovate to manage this dependency.
It is now possible to bundle DTS files of Ivy libraries since the blocker microsoft/rushstack#1029 has been addressed upstream.
DTS bundling, will cause originally namespaced imports become namespace declarations within the same file. Example:
Before bundling
```ts
import * as i1 from './router';
export declare class RouterModule {
constructor(guard: any, router: Router);
static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>;
}
```
After bundling
```
declare namespace i1 {
export {
RouterOutletContract,
RouterOutlet
}
}
export declare class RouterModule {
constructor(guard: any, router: Router);
static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>;
}
```
And therefore this commit adds support for reflecting types that are defined in such namespace declarations.
Closes #42064
|
Caretaker: I am unable to remove the unnecessary reviews. |
alan-agius4
added
action: merge
atscott
pushed a commit
that referenced
this pull request
Jul 2, 2021
It is now possible to bundle DTS files of Ivy libraries since the blocker microsoft/rushstack#1029 has been addressed upstream. PR Close #42728
atscott
pushed a commit
that referenced
this pull request
Jul 2, 2021
DTS bundling, will cause originally namespaced imports become namespace declarations within the same file. Example:
Before bundling
```ts
import * as i1 from './router';
export declare class RouterModule {
constructor(guard: any, router: Router);
static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>;
}
```
After bundling
```
declare namespace i1 {
export {
RouterOutletContract,
RouterOutlet
}
}
export declare class RouterModule {
constructor(guard: any, router: Router);
static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>;
}
```
And therefore this commit adds support for reflecting types that are defined in such namespace declarations.
Closes #42064
PR Close #42728
atscott
pushed a commit
that referenced
this pull request
Jul 2, 2021
We can now allow Renovate to manage this dependency. PR Close #42728
atscott
pushed a commit
that referenced
this pull request
Jul 2, 2021
It is now possible to bundle DTS files of Ivy libraries since the blocker microsoft/rushstack#1029 has been addressed upstream. PR Close #42728
atscott
pushed a commit
that referenced
this pull request
Jul 2, 2021
DTS bundling, will cause originally namespaced imports become namespace declarations within the same file. Example:
Before bundling
```ts
import * as i1 from './router';
export declare class RouterModule {
constructor(guard: any, router: Router);
static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>;
}
```
After bundling
```
declare namespace i1 {
export {
RouterOutletContract,
RouterOutlet
}
}
export declare class RouterModule {
constructor(guard: any, router: Router);
static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>;
}
```
And therefore this commit adds support for reflecting types that are defined in such namespace declarations.
Closes #42064
PR Close #42728
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to bundle DTS files of Ivy libraries since the blocker microsoft/rushstack#1029 has been addressed upstream.