-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ivy compatibility guide: select and trackby docs #42338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editing review complete; a few minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion; LGTM.
Editing review completed with a few suggestions. Otherwise, LGTM.
…On Wed, May 26, 2021 at 10:29 AM Andrew Scott ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In aio/content/guide/ivy-compatibility.md
<#42338 (comment)>:
> @@ -85,7 +85,10 @@ Please note that these constants are not meant to be used by 3rd party library o
* If selecting the native `<option>` element in a `<select>` where the `<option>`s are created via `*ngFor`, use the `[selected]` property of an `<option>` instead of binding to the `[value]` property of the `<select>` element (previously, you could bind to either.) [details](guide/ivy-compatibility-examples#select-value-binding)
* Embedded views (such as ones created by `*ngFor`) are now inserted in front of anchor DOM comment node (e.g. `<!--ng-for-of-->`) rather than behind it as was the case previously.
-In most cases this does not have any impact on rendered DOM.
-In some cases (such as animations delaying the removal of an embedded view) any new embedded views will be inserted after the embedded view being animated away.
-This difference only last while the animation is active, and might alter the visual appearance of the animation.
-Once the animation is finished the resulting rendered DOM is identical to that rendered with View Engine.
+ In most cases this does not have any impact on rendered DOM.
+
+ In some cases (such as animations delaying the removal of an embedded view) any new embedded views will be inserted after the embedded view being animated away.
+ This difference only last while the animation is active, and might alter the visual appearance of the animation.
+ Once the animation is finished the resulting rendered DOM is identical to that rendered with View Engine.
+
+ One additional exception is the `<select>` form control, which will have its value reset to the value of the first `<option>` when the nested `<option>` elements are dynamically rendered via `NgForOf` without a correctly provided [`trackBy`](api/common/NgForOf#ngForTrackBy) function.
👍 LGTM
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#42338 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR4DPGVTEHIGQVOSCVIQ7HDTPUVXVANCNFSM45QPSFAA>
.
--
*--Teri Glover--*
*Technical Editor*
|
An internal change in Ivy has surfaced issues in previosly broken code. This change adds a note to the Ivy compatibility guide as well as the TrackByFunction api docs. Fixes angular#35896
6259b3f
to
6d926b5
Compare
You can preview 6d926b5 at https://pr42338-6d926b5.ngbuilds.io/. |
…ide (angular#42338) An internal change in Ivy has surfaced issues in previosly broken code. This change adds a note to the Ivy compatibility guide as well as the TrackByFunction api docs. Fixes angular#35896 PR Close angular#42338
…ide (angular#42338) An internal change in Ivy has surfaced issues in previosly broken code. This change adds a note to the Ivy compatibility guide as well as the TrackByFunction api docs. Fixes angular#35896 PR Close angular#42338
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Improves #35896, but I'd like us to eventually come up with a better solution than just docs.
Please review just the last commit.