Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy compatibility guide: select and trackby docs #42338

Closed

Conversation

IgorMinar
Copy link
Contributor

@IgorMinar IgorMinar commented May 26, 2021

Improves #35896, but I'd like us to eventually come up with a better solution than just docs.

Please review just the last commit.

@google-cla google-cla bot added the cla: yes label May 26, 2021
@pullapprove pullapprove bot requested a review from alxhub May 26, 2021 00:26
@IgorMinar IgorMinar marked this pull request as draft May 26, 2021 00:26
@IgorMinar IgorMinar requested review from atscott and removed request for alxhub May 26, 2021 00:27
aio/content/guide/ivy-compatibility.md Outdated Show resolved Hide resolved
@ngbot ngbot bot added this to the Backlog milestone May 26, 2021
@IgorMinar IgorMinar requested a review from TeriGlover May 26, 2021 17:26
@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer labels May 26, 2021
Copy link
Contributor

@TeriGlover TeriGlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing review complete; a few minor suggestions.

aio/content/guide/ivy-compatibility.md Outdated Show resolved Hide resolved
aio/content/guide/ivy-compatibility.md Outdated Show resolved Hide resolved
aio/content/guide/ivy-compatibility.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TeriGlover TeriGlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion; LGTM.

aio/content/guide/ivy-compatibility.md Outdated Show resolved Hide resolved
@TeriGlover
Copy link
Contributor

TeriGlover commented May 26, 2021 via email

An internal change in Ivy has surfaced issues in previosly broken code. This change adds a note to the
Ivy compatibility guide as well as the TrackByFunction api docs.

Fixes angular#35896
@IgorMinar IgorMinar force-pushed the docs/select-and-trackby-docs branch from 6259b3f to 6d926b5 Compare May 27, 2021 17:22
@IgorMinar IgorMinar marked this pull request as ready for review May 27, 2021 17:23
@mary-poppins
Copy link

You can preview 6d926b5 at https://pr42338-6d926b5.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 27, 2021
AndrewKushnir pushed a commit that referenced this pull request May 27, 2021
…ide (#42338)

An internal change in Ivy has surfaced issues in previosly broken code. This change adds a note to the
Ivy compatibility guide as well as the TrackByFunction api docs.

Fixes #35896

PR Close #42338
umairhm pushed a commit to umairhm/angular that referenced this pull request May 28, 2021
…ide (angular#42338)

An internal change in Ivy has surfaced issues in previosly broken code. This change adds a note to the
Ivy compatibility guide as well as the TrackByFunction api docs.

Fixes angular#35896

PR Close angular#42338
iRealNirmal pushed a commit to iRealNirmal/angular that referenced this pull request Jun 4, 2021
…ide (angular#42338)

An internal change in Ivy has surfaced issues in previosly broken code. This change adds a note to the
Ivy compatibility guide as well as the TrackByFunction api docs.

Fixes angular#35896

PR Close angular#42338
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants