fix(compiler-cli): don't generate empty <target/> when extracting xliff #18072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When we extract xliff files with ng-xi18n, it creates empty
<target/>
elements in the extracted file. Xliff is the only format with that behavior.It's especially problematic for xliff because the same file can be used as source and as translation without changing the content (which is not the case for xmb/xtb that use a different markup). When using the extracted file as a translation file without changing its content, all traductions are empty and they don't trigger the missingTranslation parameter.
Issue Number: #15754
What is the new behavior?
We don't add empty
<target/>
elements to the extracted file anymore.Does this PR introduce a breaking change?