Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): don't generate empty <target/> when extracting xliff #18072

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Jul 12, 2017

PR Type

What kind of change does this PR introduce?

[x] Feature

What is the current behavior?

When we extract xliff files with ng-xi18n, it creates empty <target/> elements in the extracted file. Xliff is the only format with that behavior.
It's especially problematic for xliff because the same file can be used as source and as translation without changing the content (which is not the case for xmb/xtb that use a different markup). When using the extracted file as a translation file without changing its content, all traductions are empty and they don't trigger the missingTranslation parameter.

Issue Number: #15754

What is the new behavior?

We don't add empty <target/> elements to the extracted file anymore.

Does this PR introduce a breaking change?

[x] No

@ocombe ocombe requested a review from vicb July 12, 2017 12:53
@mary-poppins
Copy link

You can preview 4ae5a4a at https://pr18072-4ae5a4a.ngbuilds.io/.

@ocombe ocombe added area: i18n action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 12, 2017
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 18, 2017
@alxhub alxhub merged commit 65c9e13 into angular:master Jul 19, 2017
@ocombe ocombe deleted the feat-extract-target branch August 22, 2017 12:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants