Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade): WIP fix multislot transclusion on upgraded components #16627

Closed
wants to merge 2 commits into from
Closed

fix(upgrade): WIP fix multislot transclusion on upgraded components #16627

wants to merge 2 commits into from

Conversation

petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin mentioned this pull request May 8, 2017
Closed
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@gkalpak
Copy link
Member

gkalpak commented May 10, 2017

Still pending:

  • Port changes to upgrade/dynamic.
  • Detect transcluded, interpolated text nodes (e.g. {{ myProp }}), even if Angular has temporarily removed the content.

@mary-poppins
Copy link

The angular.io preview for e24b7dd is available here.

@mary-poppins
Copy link

The angular.io preview for ea371bf is available here.

gkalpak added a commit to gkalpak/angular that referenced this pull request May 29, 2017
@gkalpak
refactor(upgrade): use UpgradeHelper in the dynamic version
a5ccc1e 
This also improves `upgrade/dynamic` and brings its behavior (wrt upgraded
components) much closer to `upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This is the equivalet of angular#16627 for `upgrade/dynamic`.)

Fixes angular#11044
@mary-poppins
Copy link

The angular.io preview for 062b34f is available here.

@googlebot
Copy link

CLAs look good, thanks!

@mary-poppins
Copy link

The angular.io preview for e5e740f is available here.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mary-poppins
Copy link

The angular.io preview for a9c3431 is available here.

@gkalpak gkalpak force-pushed the upgrade-transclusion branch 2 times, most recently from 9708dd6 to 34b61be Compare May 31, 2017 19:35
@mary-poppins
Copy link

The angular.io preview for 9708dd6 is available here.

@mary-poppins
Copy link

The angular.io preview for 34b61be is available here.

gkalpak added a commit to gkalpak/angular that referenced this pull request May 31, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
e405883 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
petebacondarwin and others added 2 commits May 31, 2017 22:59
@petebacondarwin @gkalpak
fix(upgrade): WIP fix multislot transclusion on upgraded components
00792dd
@gkalpak
fix(upgrade): fix transclusion on upgraded components
0d8e818 
Previously, only simple, single-slot transclusion worked on upgraded components.
This commit fixes/adds support for the following:

- Multi-slot transclusion.
- Using fallback content when no transclusion content is provided.
- Destroy unused scope (when using fallback content).

Fixes angular#13271
@mary-poppins
Copy link

The angular.io preview for 0d8e818 is available here.

gkalpak added a commit to gkalpak/angular that referenced this pull request May 31, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
f725b6e 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
gkalpak added a commit to gkalpak/angular that referenced this pull request Jun 1, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
ca02acc 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
gkalpak added a commit to gkalpak/angular that referenced this pull request Jun 1, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
a833b72 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
@gkalpak gkalpak mentioned this pull request Jun 1, 2017
Closed
3 tasks
@gkalpak gkalpak added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 1, 2017
@gkalpak
Copy link
Member

gkalpak commented Jun 1, 2017

This is ready for review 😃

@petebacondarwin
Copy link
Member Author

Closing as #17160 includes these changes.

gkalpak added a commit to gkalpak/angular that referenced this pull request Jul 5, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
c133f3e 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
gkalpak added a commit to gkalpak/angular that referenced this pull request Jul 5, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
22a33ab 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
jasonaden pushed a commit that referenced this pull request Jul 6, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
6e7a73d 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from #16627 to the dynamic version.)

Fixes #11044
jasonaden pushed a commit to jasonaden/angular that referenced this pull request Jul 6, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
a4065a8 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
jasonaden pushed a commit to jasonaden/angular that referenced this pull request Jul 7, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
6e407ce 
This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
jasonaden pushed a commit that referenced this pull request Jul 7, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
11db3bd 
(#17971)

This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from #16627 to the dynamic version.)

Fixes #11044
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@gkalpak
fix(upgrade): bring the dynamic version closer to the static one
f019f4d 
(angular#17971)

This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@gkalpak @juleskremer
fix(upgrade): bring the dynamic version closer to the static one
681e9b6 
(angular#17971)

This commit changes the dynamic version of ngUpgrade to use `UpgradeHelper`,
thus bringing its behavior (wrt upgraded components) much closer to
`upgrade/static`. Fixes/features include:

- Fix template compilation: Now takes place in the correct DOM context, instead
  of in a detached node (thus has access to required ancestors etc).
- Fix support for the `$onInit()` lifecycle hook.
- Fix single-slot transclusion (including optional transclusion and fallback
  content).
- Add support for multi-slot transclusion (inclusing optional slots and fallback
  content).
- Add support for binding required controllers to the directive's controller
  (and make the `require` behavior more consistent with AngularJS).
- Add support for pre-/post-linking functions.

(This also ports the fixes from angular#16627 to the dynamic version.)

Fixes angular#11044
@petebacondarwin petebacondarwin deleted the upgrade-transclusion branch September 2, 2017 14:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak Awaiting requested review from gkalpak

Assignees

@gkalpak gkalpak

Labels
action: review The PR is still awaiting reviews from at least one requested reviewer cla: no type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petebacondarwin @googlebot @gkalpak @mary-poppins