Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations cannot be set via @host or Component.host #9044

Closed
matsko opened this issue Jun 6, 2016 · 8 comments
Closed

Animations cannot be set via @host or Component.host #9044

matsko opened this issue Jun 6, 2016 · 8 comments
Assignees
Labels
area: animations feature Issue that requests a new feature

Comments

@matsko
Copy link
Contributor

matsko commented Jun 6, 2016

No description provided.

@LinboLen
Copy link

the problem @host can't work always exist in systemjs(i don't know others). its because circle dependence. @host() parent: parentComponent, parentComponent is always undefined. but @host() parent: forward(()=>parentComponent) can work, though it cause typescript compile error.

in order to fetch parent componet in sub component constructor, i modified ng2 code.https://github.com/ridecrafty/angular/commit/0e66092b6d99a7e93bac00b11735890a1b7ef9cf

@vicb vicb added feature Issue that requests a new feature area: animations labels Jun 18, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 9, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 9, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 11, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 11, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 11, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 11, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 11, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 11, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 12, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 12, 2016
matsko added a commit to matsko/angular that referenced this issue Jul 12, 2016
@matsko matsko closed this as completed in 806a254 Jul 12, 2016
@colinkahn
Copy link

@matsko curious if this will solve a problem I'm having where when adding components using DynamicComponentLoader.loadNextToLocation and then removing them using ViewContainerRef.clear animations do not fire. I'm assuming the animations don't work because the trigger needs to be on the removed component host itself.

Here's an example:
https://plnkr.co/edit/Gba4dzuHIArG6rN4LYAd?p=preview

@zoechi
Copy link
Contributor

zoechi commented Jul 18, 2016

DynamicComponentLoader is deprecated. https://plnkr.co/edit/f8OY6ATuRIgsf1xYmxBO?p=preview using ViewContainerRef.createComponent() instead results in an animation exception (I don't know animations yet)

@colinkahn
Copy link

@zoechi thanks for updating the plunker. I'm not seeing the error though (Chrome Version 51.0.2704.106 (64-bit)).

@zoechi
Copy link
Contributor

zoechi commented Jul 18, 2016

TypeError: Failed to execute 'animate' on 'Element': 'null' is not a valid value for easing

52.0.2743.24 (Official Build) beta (64-bit) Linux

@colinkahn
Copy link

Looks like an animation bug w/ Linux. This works fine on Mac.

@matsko
Copy link
Contributor Author

matsko commented Jul 18, 2016

@zoechi that bug was fixed with #9780 and will be apart of RC5. For now just use linear as the easing with setting a timing (e.g. animate("1s linear", style(...))).

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: animations feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants