mutual recursion among components entered from multiple sides

[KiaraGrouwstra]

While the issue I previously submitted potentially related to mutually recursive components, I found another issue where it's much more clear-cut it triggers due to recursion, plunker here. I have:

• a LeftComp that 'could' include right: L<right *ngIf="false"></right>
• a RightComp that 'could' include left: R<left *ngIf="false"></left>
• a main component that 'could' include both: [ <left *ngIf="false"></left> <right *ngIf="false"></right> ]

Expected result: just the brackets [], since the rest should never trigger.

Actual result: if using a Karma test, then TestComponentBuilder's createAsync's promise never resolves, resulting in a Jasmine timeout; similarly, in the plunker, it remains stuck 'loading' the main component without actually throwing an error.

[KiaraGrouwstra]

To give an update on this, this still crashes in tests as of RC1. I don't see RC available on the CDN for Plunker yet, but the Plunker holds without changes (other than version) for beta 17.

[KiaraGrouwstra]

The culprit is this line:

var childIsRecursive = ListWrapper.contains(childCompilingComponentsPath, childCacheKey);

This incorrectly evaluates to false (not recursive) in the case of the above-mentioned components. (More accurately, it passes by left/right twice -- once from app, once from each other. The latter pass for each should evaluate to recursive for things to work.)

Adding the following snippet after it relaxes the recursion check so as to also evaluate to true when the current component directly references a component checked before.

ListWrapper.forEachWithIndex(childViewDirectives.map(x => x.type.runtime), descendant => {
    if (ListWrapper.contains(childCompilingComponentsPath, descendant)) {
        childIsRecursive = true;
    }
});

I'll try to make a PR for this.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}