Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router Proposal: adopt convention for route alias #4083

Closed
btford opened this issue Sep 9, 2015 · 9 comments
Closed

Router Proposal: adopt convention for route alias #4083

btford opened this issue Sep 9, 2015 · 9 comments

Comments

@btford
Copy link
Contributor

btford commented Sep 9, 2015

I propose that we adopt an enforced convention of naming convention were route names are TitleCase: MyRoute rather than camelCase myRoute.

I think it helps distinguish between URLs and the DSL. Consider:

@RouteConfig([
  { path: '/foo', component: FooCmp, as: 'MyRoute' }
])
class MyCmp
@btford btford changed the title Router: adopt convention for route alias Router Proposal: adopt convention for route alias Sep 9, 2015
@mhevery
Copy link
Contributor

mhevery commented Sep 9, 2015

MyRoute is not found in the example provided, not sure what you are referring to.

@btford
Copy link
Contributor Author

btford commented Sep 9, 2015

Updated

@IgorMinar
Copy link
Contributor

lgtm

@johnpapa
Copy link
Contributor

johnpapa commented Oct 3, 2015

I the changelog and error message it says CamelCase. I think you meant TitleCase

router: enforce convention of CamelCase names in route aliases (5298eb0), closes #4083

@btford

@jessegood
Copy link

Nitpick, but isn't the correct terminology PascalCase? Title Case I thought has spaces in between words.

@johnpapa
Copy link
Contributor

johnpapa commented Oct 3, 2015

PascalCase is not known everywhere, I found. So I have been calling it UpperCamelCase

@jessegood
Copy link

Now that you mention it, I've only seen PascalCase on MSDN or other MS-related documentation, although we are using Typescript and the TypeScript Guidlines use it.

@basvandenheuvel
Copy link

This should have been added to the breaking changes?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants