Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad exports naming for Directive/Component #2356

Closed
alexeagle opened this issue Jun 4, 2015 · 3 comments
Closed

Bad exports naming for Directive/Component #2356

alexeagle opened this issue Jun 4, 2015 · 3 comments
Assignees
Milestone

Comments

@alexeagle
Copy link
Contributor

the top-level 'angular2/angular2' module re-exports Component as ComponentAnnotation. The actual Component class extends Directive. However, we re-export class Directive as DirectiveAnnotation, and the re-exported Directive is just a var declaration. This breaks the angular2.d.ts since it ends up with a Component extends Directive type, where Directive is not a class.

Current workaround is to export the Directive annotation into the .d.ts, but this breaks the application because only decorators should be exposed to JS application.

@naomiblack
Copy link
Contributor

@alexeagle we need to discuss how to prioritize this relative to other customer-facing issues -- might need to slip to alpha-30.

@rkirov
Copy link
Contributor

rkirov commented Jun 22, 2015

The workaround is in angular2.api.ts, when this bug is fixed that file should be removed.

@naomiblack naomiblack modified the milestones: alpha-29, alpha-31 Jun 30, 2015
mhevery added a commit to mhevery/angular that referenced this issue Jul 3, 2015
mhevery added a commit to mhevery/angular that referenced this issue Jul 4, 2015
@rkirov rkirov modified the milestones: alpha-32, alpha-31 Jul 6, 2015
mhevery added a commit to mhevery/angular that referenced this issue Jul 7, 2015
mhevery added a commit to mhevery/angular that referenced this issue Jul 7, 2015
mhevery added a commit to mhevery/angular that referenced this issue Jul 7, 2015
mhevery added a commit to mhevery/angular that referenced this issue Jul 7, 2015
mhevery added a commit to mhevery/angular that referenced this issue Jul 7, 2015
@mhevery mhevery closed this as completed in 12a427e Jul 8, 2015
jteplitz pushed a commit to jteplitz/angular that referenced this issue Jul 14, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants