-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n's ph value doesn't allow single quotes, only double quotes #15318
Labels
Comments
ocombe
added a commit
to ocombe/angular
that referenced
this issue
Mar 24, 2017
The regex that extract named interpolations for i18n placeholders only allowed double quotes, this PR adds the ability to use single quotes Fixes angular#15318
ocombe
added a commit
to ocombe/angular
that referenced
this issue
Mar 24, 2017
The regex that extract named interpolations for i18n placeholders only allowed double quotes, this PR adds the ability to use single quotes Fixes angular#15318
ocombe
added a commit
to ocombe/angular
that referenced
this issue
Mar 24, 2017
The regex that extract named interpolations for i18n placeholders only allowed double quotes, this PR adds the ability to use single quotes Fixes angular#15318
sjtrimble
pushed a commit
to sjtrimble/angular
that referenced
this issue
Mar 25, 2017
vicb
pushed a commit
that referenced
this issue
Mar 29, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this issue
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this issue
Aug 28, 2017
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ... (check one with "x")
Current behavior
In i18n's ph value, only double quotes are allowed. Single quotes are not and the placeholder is ignored.
Expected behavior
Expected to be able to use single quotes too.
Minimal reproduction of the problem with instructions
The text was updated successfully, but these errors were encountered: