Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler generates references to a deprecated class. #14521

Closed
chuckjaz opened this issue Feb 15, 2017 · 1 comment · Fixed by #14523
Closed

Compiler generates references to a deprecated class. #14521

chuckjaz opened this issue Feb 15, 2017 · 1 comment · Fixed by #14523

Comments

@chuckjaz
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting

Current behavior

When using *ngFor, the compiler will generate a reference to NgFor in the provider for the component. NgFor is deprecated in favor of NgForOf<T> and will issue warning if the code is checked for references to deprecated symbols.

Expected behavior

The compiler should only generated references to deprecated classes only if a depreciated class is declared or imported into the module it is declared in and part of the template matches the selector for the component or directive.

Minimal reproduction of the problem with instructions

Any template with a *ngFor.

What is the motivation / use case for changing the behavior?

Avoiding deprecated references.
chuckjaz added a commit to chuckjaz/angular that referenced this issue Feb 16, 2017
@chuckjaz
fix(common): do not reference deprecated classes in providers
bf0a395 
Fixes angular#14521
@chuckjaz chuckjaz mentioned this issue Feb 16, 2017
Merged
chuckjaz added a commit to chuckjaz/angular that referenced this issue Feb 16, 2017
@chuckjaz
fix(common): do not reference deprecated classes in providers
67e8a6c 
Fixes angular#14521

BREAKING CHANGE: `NgFor` is no longer provided by `NgForOf<T>`.

Mitigation: Change constructor parameter references from NgFor` to `NgForOf<any>`.
chuckjaz added a commit to chuckjaz/angular that referenced this issue Feb 16, 2017
@chuckjaz
fix(common): do not reference deprecated classes in providers (angula…
ff07e1c 
…r#14523)

References to `NgFor` are now an alias for `NgForOf` instead of a
derived class.

Fixes angular#14521
chuckjaz added a commit to chuckjaz/angular that referenced this issue Feb 16, 2017
@chuckjaz
fix(common): do not reference deprecated classes in providers (angula…
2556a8d 
…r#14523)

References to `NgFor` are now an alias for `NgForOf` instead of a
derived class.

Fixes angular#14521
chuckjaz added a commit to chuckjaz/angular that referenced this issue Feb 16, 2017
@chuckjaz
fix(common): do not reference deprecated classes in providers (angula…
2afd258 
…r#14523)

References to `NgFor` are now an alias for `NgForOf` instead of a
derived class.

Fixes angular#14521
chuckjaz added a commit to chuckjaz/angular that referenced this issue Feb 16, 2017
@chuckjaz
fix(common): do not reference deprecated classes in providers (angula…
c609f00 
…r#14523)

References to `NgFor` are now an alias for `NgForOf` instead of a
derived class.

Fixes angular#14521
chuckjaz added a commit to chuckjaz/angular that referenced this issue Feb 22, 2017
@chuckjaz
fix(common): do not reference deprecated classes in providers (angula…
f48f689 
…r#14523)

References to `NgFor` are now an alias for `NgForOf` instead of a
derived class.

Fixes angular#14521
IgorMinar pushed a commit that referenced this issue Feb 24, 2017
@chuckjaz @IgorMinar
fix(common): do not reference deprecated classes in providers (#14523) (
a23634d 
#14523)

References to `NgFor` are now an alias for `NgForOf` instead of a
derived class.

Fixes #14521
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@chuckjaz
fix(common): do not reference deprecated classes in providers (angula…
93287a0 
…r#14523) (angular#14523)

References to `NgFor` are now an alias for `NgForOf` instead of a
derived class.

Fixes angular#14521
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@chuckjaz @juleskremer
fix(common): do not reference deprecated classes in providers (angula…
8a9ff08 
…r#14523) (angular#14523)

References to `NgFor` are now an alias for `NgForOf` instead of a
derived class.

Fixes angular#14521
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(common): do not reference deprecated classes in providers chuckjaz/angular
1 participant
@chuckjaz