-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict mode syntax error when running @angular/compiler 2.3.0 in PhantomJS #13301
Comments
This also fails on Chromium 37, the version used on Travis CI. It runs fine in the latest Chrome.
|
Getting the same error using:
When I revert to previously working version:
the error goes away. |
fixes angular#13301 The inner class would transpile to a nested function declaration which is not allowed in ES5. See http://eslint.org/docs/rules/no-inner-declarations
fixes #13301 The inner class would transpile to a nested function declaration which is not allowed in ES5. See http://eslint.org/docs/rules/no-inner-declarations
Will there be a point release for this on npm? |
they don't do releases on Friday. you can use |
is there a work around for this until fix? i just want to test a basic build with the "app works" simple code. |
use the code in 4022173 (const -> var) |
and should be in *-builds soon |
fixes #13301 The inner class would transpile to a nested function declaration which is not allowed in ES5. See http://eslint.org/docs/rules/no-inner-declarations
to fix karma test (nested function error) angular/angular#13301
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a ...
Current behavior
Running
@angular/compiler
in PhantomJS results in an error:The offending code can be found in
@angular/compiler/bundles/compiler.umd.js:26587
:Expected behavior
The code should run in PhantomJS
Minimal reproduction of the problem with instructions
See tsvetomir/phantomjs-angular-2.3 for a runnable sample.
git clone [email protected]:tsvetomir/phantomjs-angular-2.3.git
cd phantomjs-angular-2.3
npm install
./node_modules/.bin/phantomjs script.js
What is the motivation / use case for changing the behavior?
The shipped code shouldn't violate Strict Mode restrictions.
Please tell us about your environment:
Angular version: 2.3.0
Browser: PhantomJS 2.1.7
Language: TypeScript 2.1
Node (for AoT issues): 4.7
The text was updated successfully, but these errors were encountered: