Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbeddedView destroy issue #13062

Closed
pkozlowski-opensource opened this issue Nov 23, 2016 · 2 comments · Fixed by #13459
Closed

EmbeddedView destroy issue #13062

pkozlowski-opensource opened this issue Nov 23, 2016 · 2 comments · Fixed by #13459
Labels
area: core Issues related to the framework runtime freq1: low type: bug/fix

Comments

@pkozlowski-opensource
Copy link
Member

As discussed with @tbosch there seems to be an issue with internal data structures when:

  • a component is created dynamically
  • an EmbeddedView is created dynamically (from TemplateRef) and its nodes are used to fill in a "hole" in a component

Given the above conditions it is not possible to properly destroy an EmbeddedView as the "Cannot read property 'indexOf' of undefined" error is thrown from AppView detatch method. Here is a plunker that illustrates this: http://plnkr.co/edit/XOVSN1BsimR7oToFO3Du?p=preview (open a modal, close it and see the error in the console).

Angular version 2.3.0-beta.1 (pinned in the above plunker)

@pkozlowski-opensource
Copy link
Member Author

Here is a simplified plunker that doesn't use any services, component factories etc. This is just a basic EmbeddedView that gets attached to ApplicationRef and then destroyed. Same error: http://plnkr.co/edit/us8Ue7iRjnbUGmFJSloL?p=preview

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime freq1: low type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants