fix(ngModel): use $evalAsync for blur events to safely $apply

[alexanderchan]

Set the $touched asynchronously using $evalAsync if the element is blurred during an $apply, otherwise it keeps the old behaviour.

Fixes #8762

[Narretz]

You should check $rootScope.$phase, like here https://github.com/angular/angular.js/blob/master/src/ng/directive/ngEventDirs.js#L62

[gkalpak]

@Narretz means $rootScope.$$phase (just clearing it up to avoid confusion 😈).

[alexanderchan]

Sounds good I'll try to update that. I followed 719c747#diff-eefe7d65b6795cba34d2b08a27ebf2beR63 which only checked scope.$$phase.

Just to help my understanding is there a reason $rootScope.$$phase isn't used there? @tbosch thanks!

Ahh, sorry I see now, it came afterwards I should have checked the most recent version. Thanks for the tips guys.

[Narretz]

Thanks for the clarification @gkalpak Why $rootScope is explained here: #8849 (comment)

[alexanderchan]

@Narretz thanks for all your help with this one. Do you think it also makes sense to update the example in the docs at https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L1645 with a check of the $rootScope.$$phase for the blur event? If so I can try to update this pr.

[alexanderchan]

On second thought, if you think it is useful I might open a different PR as a doc fix as I might not have as much time in the upcoming evenings.

[Narretz]

Please so! We can merge doc fixes faster anyway

----- Ursprüngliche Nachricht -----
Von: "Alex" [email protected]
Gesendet: ‎29.‎10.‎2014 22:37
An: "angular/angular.js" [email protected]
Cc: "Narretz" [email protected]
Betreff: Re: [angular.js] fix(ngModel): use $evalAsync for blur events tosafely $apply (#9808)

On second thought, if you think it is useful I might open a different PR as a doc fix as I might not have as much time in the upcoming evenings.
—
Reply to this email directly or view it on GitHub.=

[gkalpak]

I don't think we should promote the use of private, undocumented APIs (such as $$phase) in the examples.
@Narretz, wdyt ?

[alexanderchan]

That's a good point, I wonder instead if the solution would be to have a public safe apply function that internally checks the phase and does the right thing accordingly.

On Oct 30, 2014, at 07:15, Georgios Kalpakas [email protected] wrote:

I don't think we should promote using private, undocumented APIs (such as $$phase) in the examples.
@Narretz, wdyt ?

—
Reply to this email directly or view it on GitHub.

[Narretz]

That's true, I thought the example already used $$phase, but on the scope. Let's not introduce private apis in examples then. safeApply is a different topic. You can open an issue about this, but it has been shot down a few times.

[gkalpak]

Why not just use $evalAsync() ? It's a form of safe $apply anyway (the only difference being that it executes the code "asyncronously", i.e. after the calling function has executed).

[Narretz]

@gkalpak Good question. I actually don't know. In #6910 this was discussed, and it links to more discussion, but I can't tell with 100% certainty.

[Narretz]

Anyway, this looks good to me now

[gkalpak]

@Narretz: Not sure if it was clear, but I meant why not use $evalAsync in the docs example.

[Narretz]

Oh, okay. Yeah, I wanted to ask if you meant that, but then I didn't somehow :)

[Narretz]

Is there a specifc reason why the first two expects are inside the $apply block?

[alexanderchan]

@Narretz there is no specific reason for the two expects to be in there. Do you think it would be better to move them just before the apply block? I was just trying to ensure that the touched and untouched state remained exactly the same before and after the blur event.