This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Pushed for CI: perf(ngBind): set textContent rather than using element.text() #9396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Speeds up chrome with ~10% firefox by ~5%" We don't really see this result in benchmarks (https://www.dropbox.com/s/76wxqbvduade52s/big_table_benchmark_b1ee5396_vs_d580a954.zip?dl=0) However, it's basically harmless. Side effects: Use strict equality check for `undefined` to replace with empty string. Most target browsers will output `undefined` rather than the empty string if we don't do this. Previously, ngBindTemplate did not perform this check. However the change has been made to make behaviour consistent across all target browsers (chrome does output the empty string). Closes angular#9369
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Speeds up chrome with ~10% firefox by ~5%"
We don't really see this result in benchmarks
(https://www.dropbox.com/s/76wxqbvduade52s/big_table_benchmark_b1ee5396_vs_d580a954.zip?dl=0)
However, it's basically harmless.
Side effects:
Use strict equality check for
undefinedto replace with empty string. Mosttarget browsers will output
undefinedrather than the empty string if wedon't do this. Previously, ngBindTemplate did not perform this check. However
the change has been made to make behaviour consistent across all target
browsers (chrome does output the empty string).
Closes #9369