This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
test(attrs): remove invalid test from e2e suite #9214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is incorrectly acting as documentation that the anchor tag directive will preventDefault on clicks on elements with a name. This has not been the case ever since f3de5b6 Closes angular#6554
|
@petebacondarwin could you review? The test actually passes, I believe because $location is not injected anywhere. However, people are looking at this test and making assumptions about the behaviour of the library |
|
I tried injecting Also, I think that the issue in #6554 is incorrectly referencing the |
|
Related to #6273 |
petebacondarwin
referenced
this pull request
Oct 1, 2014
Change the a directive to link and hookup a click event only when there is no href or name in the template element. In a large Google app, this results in about 800 fewer registrations, saving a small but measurable amount of time and memory. Closes #5362
|
Closing as a dupe of #6273 as I think we should fix this behaviour rather than removing the test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is incorrectly acting as documentation that the anchor tag directive
will preventDefault on clicks on elements with a name. This has not been the
case ever since f3de5b6
Closes #6554