This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(script): Incorrectly reading script text on ie (follow-up) #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did more testing and IE with .html() always prepends '\n' to the result, where as .text does not |
The solution proposed by Misko (#0ec13428d7ba1cff67cde43bc90277481cab82ba) break the code for Chrome. The JQuery docs says: "To get the value of a script element, use the .html() method." (http://api.jquery.com/text/)
|
I didn't succeed to reproduce the bug with Chrome so it should have come from elsewhere, my bad. I've removed the tagName check as requested. I've also observed that IE prepends the '\n'. Since the content of the script text should be html I don't know if that really matters though. |
|
I think the \n is a problem, so I think I am going to leave it this way. |
|
Fair enough. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution proposed by Misko (#0ec13428d7ba1cff67cde43bc90277481cab82ba) break the code for Chrome. The JQuery docs says: "To get the value of a script element, use the .html() method." (http://api.jquery.com/text/)