Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fix ngRepeat to allow keys starting with $ #8845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harikrishnan83
Copy link

Dear angular team,

The issue that this PR is addressing is very similar to #1463. ngRepeat Directive does not show object/map keys that begin with $. Plunker link http://plnkr.co/edit/0bzuZbzrVX9xLP7e6oHL?p=preview.

I have followed the same idea that was used in PR #6253.

Thanks for all the great work.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford
Copy link
Contributor

btford commented Sep 3, 2014

@IgorMinar @tbosch Do we want this?

@btford btford added this to the Backlog milestone Sep 3, 2014
@tbosch
Copy link
Contributor

tbosch commented Sep 3, 2014

This could break if someone wants to iterate over all properties of $scope using (key,value) in this, so this would be a breaking change.

@IgorMinar What do you think?

@srl295
Copy link

srl295 commented Nov 13, 2015

(a year later) Is this planned to go in? I didn't see the current behavior documented in ngRepeat docs that I could find, and was an unpleasant surprise. Yeah I know, dollar signs, but they do show up in remote data.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants