-
Notifications
You must be signed in to change notification settings - Fork 27.5k
Fix ngRepeat to allow keys starting with $ #8845
base: master
Are you sure you want to change the base?
Fix ngRepeat to allow keys starting with $ #8845
Conversation
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
@IgorMinar @tbosch Do we want this? |
This could break if someone wants to iterate over all properties of @IgorMinar What do you think? |
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
(a year later) Is this planned to go in? I didn't see the current behavior documented in ngRepeat docs that I could find, and was an unpleasant surprise. Yeah I know, dollar signs, but they do show up in remote data. |
Dear angular team,
The issue that this PR is addressing is very similar to #1463. ngRepeat Directive does not show object/map keys that begin with $. Plunker link http://plnkr.co/edit/0bzuZbzrVX9xLP7e6oHL?p=preview.
I have followed the same idea that was used in PR #6253.
Thanks for all the great work.