feat(dateFilter): Add option to display date as am/pm #8830
Conversation
wesleycho
force-pushed
the
am_pm_capitalization
branch
from
4b7f044 to
9ab8e2e
Compare
This adds a new option in order to choose whether to display a date as AM/PM or am/pm. Fix jshint error Fix regexp, update docs
wesleycho
force-pushed
the
am_pm_capitalization
branch
from
9ab8e2e to
763b14f
Compare
| function ampmGetter(date, formats) { | ||
| return date.getHours() < 12 ? formats.AMPMS[0] : formats.AMPMS[1]; | ||
| function ampmGetter(capitalLetters) { | ||
| var ampms = (capitalLetters) ? 'AMPMS' : 'ampms'; |
There was a problem hiding this comment.
The property 'ampms' is not defined in any of the locales
|
There are other issues with the PR, but I think that the biggest one is that the CLDR does not make this distinction. This is why I am closing this PR. |
|
@lgalfaso I found myself needing lowercase am/pm today and am interested in adding it. I don't fully understand the issue you've outlined above. Can you explain what the CLDR is and what needs to be added to the built-in i18n locales? |
|
@jnraine the CLDR is the Unicode Common Locale Data Repository that is from where many libraries extract the date/time symbols for the many locales. It also has a reference for many of the date/time patterns, and to do so it defines the symbols, again, commonly used in many libraries (http://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table). Now, even when the information at the CLDR is very extensive, it does not cover every use case. Eg it does not cover lower case version of the time period (ie, am/pm). It would be close to impossible for an independent library to add and maintain a symbol that is not in the CLDR, as the amount of work would be overwhelming and the benefit would be very limited. I would recommend you that you just add the filter |
This adds a new option in order to choose whether to display a date as
AM/PM or am/pm.
Note: This contains a breaking change.
anow will display am/pm,whereas the old behavior is specified by
Afor AM/PM.This is in support of #8763 .