Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

testing fail tutorial step_08.ngdoc #6930

Closed
wants to merge 1 commit into from
Closed

Conversation

Nipol
Copy link
Contributor

@Nipol Nipol commented Mar 31, 2014

Request Type: docs

How to reproduce: angular-phon�ecat tutorial moved to step_08
and running controllerSpec.js to karma testing

Component(s):

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

Users test angularjs tutorial. and finally reach to the 08 step.
karma testing is fail.
fore documents(step_05.ngdoc) not describe that Global Module Loaded.

Other Comments:

fore documents(step_05.ngdoc) not describe that Global Module Loaded

fore documents(step_05.ngdoc) not describe that Global Module Loaded
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6930)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Nipol Nipol added cla: no and removed cla: yes labels Mar 31, 2014
@Nipol Nipol changed the title testing fail this step_08.ngdoc testing fail tutorial step_08.ngdoc Mar 31, 2014
@Nipol
Copy link
Contributor Author

Nipol commented Apr 1, 2014

I'm sign up! CLA.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@Nipol Nipol added cla: yes and removed cla: no labels Apr 1, 2014
petebacondarwin pushed a commit that referenced this pull request Apr 4, 2014
@Nipol Nipol deleted the patch-1 branch April 6, 2014 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants