Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ie8 fix for html5mode route #6834

Closed
wants to merge 1 commit into from
Closed

Conversation

LorDOniX
Copy link

This is my fix for IE8 router problem - #6832 (issue is described here).

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6834)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@LorDOniX LorDOniX added cla: no and removed cla: yes labels Mar 25, 2014
@LorDOniX
Copy link
Author

Thank you for your reply, I've already signed CLA signature.

@LorDOniX LorDOniX added cla: no and removed cla: yes labels Mar 26, 2014
@ashleygwilliams ashleygwilliams added this to the Backlog milestone Mar 27, 2014
@LorDOniX LorDOniX added cla: no and removed cla: yes labels Mar 28, 2014
@caitp
Copy link
Contributor

caitp commented Apr 17, 2014

I think #6899 probably fixes these issues, but I'm not positive. I'm going to close them with it, but you're welcome to re-open if they don't.

@caitp caitp closed this in 3f04770 Apr 17, 2014
caitp pushed a commit to caitp/angular.js that referenced this pull request Apr 17, 2014
…Mode

Previously, LocationHashbangInHtml5Url, which is used when html5Mode is enabled
in browsers which do not support the history API (IE8/9), would behave very
inconsistently WRT relative URLs always being resolved relative to the app root
url.

This fix enables these legacy browsers to behave like history enabled browsers,
by processing href attributes in order to resolve urls correctly.

Closes angular#6162
Closes angular#6421
Closes angular#6899
Closes angular#6832
Closes angular#6834
caitp pushed a commit that referenced this pull request Apr 18, 2014
…Mode

Previously, LocationHashbangInHtml5Url, which is used when html5Mode is enabled
in browsers which do not support the history API (IE8/9), would behave very
inconsistently WRT relative URLs always being resolved relative to the app root
url.

This fix enables these legacy browsers to behave like history enabled browsers,
by processing href attributes in order to resolve urls correctly.

Closes #6162
Closes #6421
Closes #6899
Closes #6832
Closes #6834
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants